NTP-12012 | Sohan Reddy | Removed unnecessary api calls on app (#13582)

This commit is contained in:
Sohan Reddy Atukula
2024-11-14 17:17:50 +05:30
committed by GitHub
parent b61c8ae4f6
commit f285c810f5
4 changed files with 5 additions and 46 deletions

View File

@@ -278,7 +278,6 @@ fun CoinHomeScreen(
bundleData?.getString(AUTO_REDEEM_KEY)?.let {
coinHomeScreenVM.triggerAutoRedemption(it == TRUE)
}
coinHomeScreenVM.fetchAndSaveCoinHistoryScreen()
coinHomeScreenVM.prefetchShareabilityImages()
coinHomeScreenVM.prefetchReferralShareabilityImages()
naviCoinsAnalytics.sendEvent(NaviCoinsAnalytics.REWARDS_NAVI_COINS_INFO_PAGE_LANDS)

View File

@@ -207,31 +207,6 @@ constructor(
}
}
fun fetchAndSaveCoinHistoryScreen() {
launch {
coinHistoryScreenRepo
.fetchCoinHistoryScreenCoinBalanceUiTronConfigs(
metricInfo = MetricInfo.CoinMetric(screen = screenName, isNae = { false })
)
.collect { response ->
if (response.isValidResponse()) {
cacheCoinHomeImages(response.data?.screenStructure)
}
}
}
launch {
coinHistoryScreenRepo
.fetchCoinHistoryScreenCashRewardsUiTronConfigs(
metricInfo = MetricInfo.CoinMetric(screen = screenName, isNae = { false })
)
.collect { response ->
if (response.isValidResponse()) {
cacheCoinHomeImages(response.data?.screenStructure)
}
}
}
}
fun prefetchShareabilityImages() {
launch { cacheListOfImageUrls(SHAREABILITY_URLS) }
}
@@ -240,20 +215,6 @@ constructor(
launch { cacheListOfImageUrls(REFERRAL_SHAREABILITY_URLS) }
}
fun fetchAndSaveCoinHomeScreen() {
launch {
coinHomeScreenRepo
.fetchCoinHomeScreenUiTronConfigs(
metricInfo = MetricInfo.CoinMetric(screen = screenName, isNae = { false })
)
.collect {
if (it.isValidResponse()) {
initCoinHomeScreenImageCaching(it?.data?.screenStructure)
}
}
}
}
private fun initCoinHomeScreenImageCaching(
screenDefinitionStructure: ScreenStructure?,
) {

View File

@@ -26,6 +26,7 @@ import io.mockk.impl.annotations.RelaxedMockK
import io.mockk.unmockkAll
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.InternalCoroutinesApi
import kotlinx.coroutines.flow.flow
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.test.resetMain
import org.junit.After
@@ -66,12 +67,12 @@ class CoinHomeScreenVMTest {
runBlocking(testDispatcher) {
val mockData = ScreenDefinition(screenStructure = ScreenStructure(screenId = "1"))
val response = RepoResult(data = mockData, error = ErrorMessage(400))
coEvery { coinHomeScreenRepo.fetchCoinHomeScreenUiTronConfigs() } returns response
coEvery {
coinHomeScreenRepo.fetchCoinHomeScreenUiTronConfigs(metricInfo = any())
} returns flow { emit(response) }
coEvery { naviCacheRepository.save(any()) } returns Unit
val coinHomeScreenVM =
CoinHomeScreenVM(coinHomeScreenRepo, coinHistoryScreenRepo, naviCacheRepository)
val coinHomeScreenVM = CoinHomeScreenVM(coinHomeScreenRepo, coinHistoryScreenRepo)
coinHomeScreenVM.updateCoroutineScope(this)
coinHomeScreenVM.fetchAndSaveCoinHomeScreen()
coVerify(exactly = 0) { naviCacheRepository.save(any()) }
}
}

View File

@@ -490,9 +490,7 @@ fun ReferralHomeScreen(
}
LaunchedEffect(Unit) {
referralHomeVM.fetchReferralPopupScreen()
fetchAndSaveRefereeTrackerDetails()
referralHomeVM.fetchLeaderboardPopUp()
leaderboardScreenVM.fetchAndSaveLeaderboardScreen()
if (referralHomeScreenState !is ReferralHomeScreenState.Success)
referralHomeVM.fetchReferralForgeScreen()