From f285c810f520561189aeb27a0c49d0408f759990 Mon Sep 17 00:00:00 2001 From: Sohan Reddy Atukula Date: Thu, 14 Nov 2024 17:17:50 +0530 Subject: [PATCH] NTP-12012 | Sohan Reddy | Removed unnecessary api calls on app (#13582) --- .../coin/ui/compose/screen/CoinHomeScreen.kt | 1 - .../java/com/navi/coin/vm/CoinHomeScreenVM.kt | 39 ------------------- .../com/navi/coins/vm/CoinHomeScreenVMTest.kt | 9 +++-- .../rr/referral/ui/compose/RefereeHomePage.kt | 2 - 4 files changed, 5 insertions(+), 46 deletions(-) diff --git a/android/navi-coin/src/main/java/com/navi/coin/ui/compose/screen/CoinHomeScreen.kt b/android/navi-coin/src/main/java/com/navi/coin/ui/compose/screen/CoinHomeScreen.kt index 8e8f335da9..b711e49e89 100644 --- a/android/navi-coin/src/main/java/com/navi/coin/ui/compose/screen/CoinHomeScreen.kt +++ b/android/navi-coin/src/main/java/com/navi/coin/ui/compose/screen/CoinHomeScreen.kt @@ -278,7 +278,6 @@ fun CoinHomeScreen( bundleData?.getString(AUTO_REDEEM_KEY)?.let { coinHomeScreenVM.triggerAutoRedemption(it == TRUE) } - coinHomeScreenVM.fetchAndSaveCoinHistoryScreen() coinHomeScreenVM.prefetchShareabilityImages() coinHomeScreenVM.prefetchReferralShareabilityImages() naviCoinsAnalytics.sendEvent(NaviCoinsAnalytics.REWARDS_NAVI_COINS_INFO_PAGE_LANDS) diff --git a/android/navi-coin/src/main/java/com/navi/coin/vm/CoinHomeScreenVM.kt b/android/navi-coin/src/main/java/com/navi/coin/vm/CoinHomeScreenVM.kt index c93c25d22b..745d79136f 100644 --- a/android/navi-coin/src/main/java/com/navi/coin/vm/CoinHomeScreenVM.kt +++ b/android/navi-coin/src/main/java/com/navi/coin/vm/CoinHomeScreenVM.kt @@ -207,31 +207,6 @@ constructor( } } - fun fetchAndSaveCoinHistoryScreen() { - launch { - coinHistoryScreenRepo - .fetchCoinHistoryScreenCoinBalanceUiTronConfigs( - metricInfo = MetricInfo.CoinMetric(screen = screenName, isNae = { false }) - ) - .collect { response -> - if (response.isValidResponse()) { - cacheCoinHomeImages(response.data?.screenStructure) - } - } - } - launch { - coinHistoryScreenRepo - .fetchCoinHistoryScreenCashRewardsUiTronConfigs( - metricInfo = MetricInfo.CoinMetric(screen = screenName, isNae = { false }) - ) - .collect { response -> - if (response.isValidResponse()) { - cacheCoinHomeImages(response.data?.screenStructure) - } - } - } - } - fun prefetchShareabilityImages() { launch { cacheListOfImageUrls(SHAREABILITY_URLS) } } @@ -240,20 +215,6 @@ constructor( launch { cacheListOfImageUrls(REFERRAL_SHAREABILITY_URLS) } } - fun fetchAndSaveCoinHomeScreen() { - launch { - coinHomeScreenRepo - .fetchCoinHomeScreenUiTronConfigs( - metricInfo = MetricInfo.CoinMetric(screen = screenName, isNae = { false }) - ) - .collect { - if (it.isValidResponse()) { - initCoinHomeScreenImageCaching(it?.data?.screenStructure) - } - } - } - } - private fun initCoinHomeScreenImageCaching( screenDefinitionStructure: ScreenStructure?, ) { diff --git a/android/navi-coin/src/test/java/com/navi/coins/vm/CoinHomeScreenVMTest.kt b/android/navi-coin/src/test/java/com/navi/coins/vm/CoinHomeScreenVMTest.kt index 9249448a00..f87ee149ed 100644 --- a/android/navi-coin/src/test/java/com/navi/coins/vm/CoinHomeScreenVMTest.kt +++ b/android/navi-coin/src/test/java/com/navi/coins/vm/CoinHomeScreenVMTest.kt @@ -26,6 +26,7 @@ import io.mockk.impl.annotations.RelaxedMockK import io.mockk.unmockkAll import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.InternalCoroutinesApi +import kotlinx.coroutines.flow.flow import kotlinx.coroutines.runBlocking import kotlinx.coroutines.test.resetMain import org.junit.After @@ -66,12 +67,12 @@ class CoinHomeScreenVMTest { runBlocking(testDispatcher) { val mockData = ScreenDefinition(screenStructure = ScreenStructure(screenId = "1")) val response = RepoResult(data = mockData, error = ErrorMessage(400)) - coEvery { coinHomeScreenRepo.fetchCoinHomeScreenUiTronConfigs() } returns response + coEvery { + coinHomeScreenRepo.fetchCoinHomeScreenUiTronConfigs(metricInfo = any()) + } returns flow { emit(response) } coEvery { naviCacheRepository.save(any()) } returns Unit - val coinHomeScreenVM = - CoinHomeScreenVM(coinHomeScreenRepo, coinHistoryScreenRepo, naviCacheRepository) + val coinHomeScreenVM = CoinHomeScreenVM(coinHomeScreenRepo, coinHistoryScreenRepo) coinHomeScreenVM.updateCoroutineScope(this) - coinHomeScreenVM.fetchAndSaveCoinHomeScreen() coVerify(exactly = 0) { naviCacheRepository.save(any()) } } } diff --git a/android/navi-rr/src/main/java/com/navi/rr/referral/ui/compose/RefereeHomePage.kt b/android/navi-rr/src/main/java/com/navi/rr/referral/ui/compose/RefereeHomePage.kt index e13e0b9944..6f323137af 100644 --- a/android/navi-rr/src/main/java/com/navi/rr/referral/ui/compose/RefereeHomePage.kt +++ b/android/navi-rr/src/main/java/com/navi/rr/referral/ui/compose/RefereeHomePage.kt @@ -490,9 +490,7 @@ fun ReferralHomeScreen( } LaunchedEffect(Unit) { - referralHomeVM.fetchReferralPopupScreen() fetchAndSaveRefereeTrackerDetails() - referralHomeVM.fetchLeaderboardPopUp() leaderboardScreenVM.fetchAndSaveLeaderboardScreen() if (referralHomeScreenState !is ReferralHomeScreenState.Success) referralHomeVM.fetchReferralForgeScreen()