varnitgoyal95/litmus-be
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TP-26660 | seperate out teamName and vertical (#58)

Browse Source
This commit is contained in:
Akshat Soni
2023-04-27 14:34:12 +05:30
committed by GitHub Enterprise
parent 9182687c1c
commit 950dcb2999
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
litmus-core/src/main/java/com/navi/medici/service/experiment/ExperimentServiceImpl.java
View File

@@ -100,7 +100,7 @@ public class ExperimentServiceImpl implements ExperimentService {
public DashboardExperimentResponse createExperiment(CreateExperimentRequest request, String emailId) {
log.info("Received create experiment request : {}", request.toString());
experimentValidator.validateCreateExperimentRequest(request);
Optional<TeamEntity> team = teamQuery.findByTeamName(request.getVertical());
Optional<TeamEntity> team = teamQuery.findByTeamName(request.getTeamName());
List<ActivationStrategy> strategies = request.getStrategies();
List<VariantDefinition> variants = request.getVariants();
strategies.forEach(strategy -> {
@@ -123,7 +123,7 @@ public class ExperimentServiceImpl implements ExperimentService {
? null
: jacksonUtils.objectToString(variants))
.type(ExperimentType.EXPERIMENT)
.vertical(team.map(TeamEntity::getTeamName).orElse(null))
.vertical(request.getVertical())
.createdBy(emailId)
.build();
Optional<MetricEntity> primaryMetric = metricQuery.findByMetricName(request.getPrimaryMetric());

1
litmus-model/src/main/java/com/navi/medici/request/v1/CreateExperimentRequest.java
View File

@@ -27,6 +27,7 @@ public class CreateExperimentRequest {
List<VariantDefinition> variants;
String type;
String vertical;
String teamName;
long sampleSizeRequired;
double baselineConversion;
double minimumDetectableEffect;