From 950dcb2999b4905185d822426e8bf5869ac4dd2e Mon Sep 17 00:00:00 2001 From: Akshat Soni Date: Thu, 27 Apr 2023 14:34:12 +0530 Subject: [PATCH] TP-26660 | seperate out teamName and vertical (#58) --- .../navi/medici/service/experiment/ExperimentServiceImpl.java | 4 ++-- .../com/navi/medici/request/v1/CreateExperimentRequest.java | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/litmus-core/src/main/java/com/navi/medici/service/experiment/ExperimentServiceImpl.java b/litmus-core/src/main/java/com/navi/medici/service/experiment/ExperimentServiceImpl.java index 7d4695b..63c72f7 100644 --- a/litmus-core/src/main/java/com/navi/medici/service/experiment/ExperimentServiceImpl.java +++ b/litmus-core/src/main/java/com/navi/medici/service/experiment/ExperimentServiceImpl.java @@ -100,7 +100,7 @@ public class ExperimentServiceImpl implements ExperimentService { public DashboardExperimentResponse createExperiment(CreateExperimentRequest request, String emailId) { log.info("Received create experiment request : {}", request.toString()); experimentValidator.validateCreateExperimentRequest(request); - Optional team = teamQuery.findByTeamName(request.getVertical()); + Optional team = teamQuery.findByTeamName(request.getTeamName()); List strategies = request.getStrategies(); List variants = request.getVariants(); strategies.forEach(strategy -> { @@ -123,7 +123,7 @@ public class ExperimentServiceImpl implements ExperimentService { ? null : jacksonUtils.objectToString(variants)) .type(ExperimentType.EXPERIMENT) - .vertical(team.map(TeamEntity::getTeamName).orElse(null)) + .vertical(request.getVertical()) .createdBy(emailId) .build(); Optional primaryMetric = metricQuery.findByMetricName(request.getPrimaryMetric()); diff --git a/litmus-model/src/main/java/com/navi/medici/request/v1/CreateExperimentRequest.java b/litmus-model/src/main/java/com/navi/medici/request/v1/CreateExperimentRequest.java index 1d920ab..a95e215 100644 --- a/litmus-model/src/main/java/com/navi/medici/request/v1/CreateExperimentRequest.java +++ b/litmus-model/src/main/java/com/navi/medici/request/v1/CreateExperimentRequest.java @@ -27,6 +27,7 @@ public class CreateExperimentRequest { List variants; String type; String vertical; + String teamName; long sampleSizeRequired; double baselineConversion; double minimumDetectableEffect;