varnitgoyal95/houston-be
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TP-54495 | Removed @here in rca generation message (#351)

Browse Source 
* TP-38709 | Merging the changes to master on the logfix

* TP-54495 | Removed @here in rca generation message
This commit is contained in:
Ajay Devarakonda
2024-01-17 12:03:12 +05:30
committed by GitHub
parent 8e7619f972
commit bc21096b6e
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
service/rca/rca_service.go
View File

@@ -117,7 +117,7 @@ func (r *RcaService) PostRcaToIncidentChannel(postRcaRequest service.PostRcaRequ
}
_, err = r.slackService.PostMessageByChannelID(
fmt.Sprintf("<!here> System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", successData.RcaLink),
fmt.Sprintf("System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", successData.RcaLink),
false,
incidentEntity.SlackChannel,
)

4
service/rca/rca_service_test.go
View File

@@ -64,7 +64,7 @@ func TestRcaService_PostRcaToIncidentChannel_Success(t *testing.T) {
rcaRepository.UpdateRcaMock.When(testRca).Then(nil)
slackService.PostMessageByChannelIDMock.When(
fmt.Sprintf("<!here> System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"),
fmt.Sprintf("System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"),
false,
"1234",
).Then("", nil)
@@ -176,7 +176,7 @@ func TestRcaService_PostRcaToIncidentChannel_SlackFailure_RcaSuccessCase(t *test
rcaRepository.UpdateRcaMock.When(testRca).Then(nil)
slackService.PostMessageByChannelIDMock.When(
fmt.Sprintf("<!here> System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"),
fmt.Sprintf("System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"),
false,
"1234",
).Then("", errors.New("failed to send message"))