From bc21096b6e2db91b65f79e5bd979b1f6ae66c0ac Mon Sep 17 00:00:00 2001 From: Ajay Devarakonda Date: Wed, 17 Jan 2024 12:03:12 +0530 Subject: [PATCH] TP-54495 | Removed @here in rca generation message (#351) * TP-38709 | Merging the changes to master on the logfix * TP-54495 | Removed @here in rca generation message --- service/rca/rca_service.go | 2 +- service/rca/rca_service_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/service/rca/rca_service.go b/service/rca/rca_service.go index 14c2740..366dbd0 100644 --- a/service/rca/rca_service.go +++ b/service/rca/rca_service.go @@ -117,7 +117,7 @@ func (r *RcaService) PostRcaToIncidentChannel(postRcaRequest service.PostRcaRequ } _, err = r.slackService.PostMessageByChannelID( - fmt.Sprintf(" System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", successData.RcaLink), + fmt.Sprintf("System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", successData.RcaLink), false, incidentEntity.SlackChannel, ) diff --git a/service/rca/rca_service_test.go b/service/rca/rca_service_test.go index b3c385e..807821c 100644 --- a/service/rca/rca_service_test.go +++ b/service/rca/rca_service_test.go @@ -64,7 +64,7 @@ func TestRcaService_PostRcaToIncidentChannel_Success(t *testing.T) { rcaRepository.UpdateRcaMock.When(testRca).Then(nil) slackService.PostMessageByChannelIDMock.When( - fmt.Sprintf(" System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"), + fmt.Sprintf("System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"), false, "1234", ).Then("", nil) @@ -176,7 +176,7 @@ func TestRcaService_PostRcaToIncidentChannel_SlackFailure_RcaSuccessCase(t *test rcaRepository.UpdateRcaMock.When(testRca).Then(nil) slackService.PostMessageByChannelIDMock.When( - fmt.Sprintf(" System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"), + fmt.Sprintf("System generated *DRAFT* version of RCA for this incident can be viewed *<%s|here>*", "test_link"), false, "1234", ).Then("", errors.New("failed to send message"))