varnitgoyal95/super-app
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

NTP-67254 | Investments regression fixes (#16295)

Browse Source
This commit is contained in:
Varun Jain
2025-05-26 15:26:24 +05:30
committed by GitHub
parent fd71355ed2
commit d2ffb3e6ea
4 changed files with 5 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
android/app/src/main/java/com/naviapp/home/common/hopperProcessor/processHandlerImpl/HopperHelper.kt
View File

@@ -40,7 +40,6 @@ import com.navi.amc.utils.Constant.SIP_REFERENCE_ID
import com.navi.analytics.utils.NaviTrackEvent
import com.navi.base.model.CtaData
import com.navi.common.utils.Constants.AMC_GOAL_BASED_SIP_AMOUNT_SCREEN
import com.navi.common.utils.Constants.AMC_GOAL_BASED_SIP_SUMMARY_SCREEN
import com.navi.common.utils.Constants.AMC_GOAL_BASED_SIP_TARGET_SETUP_SCREEN
import com.navi.common.utils.Constants.CTAData
import com.navi.common.utils.Constants.HOPPER_API_RESPONSE_NOT_RECEIVED
@@ -225,21 +224,8 @@ class HopperHelper {
onResult,
)
}
AMC_GOAL_BASED_SIP_SUMMARY_SCREEN -> {
viewModel.fetchGoalSummaryScreenDataFromRemote(
screenName = AMC_GOAL_BASED_SIP_SUMMARY_SCREEN,
goalReferenceId =
ctaData.parameters
?.firstOrNull { it.key == GOAL_REFERENCE_ID }
?.value
.orEmpty(),
)
observeAndHandleResponse(
activity,
ctaData,
viewModel.goalSummaryScreenData,
onResult,
)
else -> {
onResult(true)
}
}
}

2
android/navi-amc/src/main/java/com/navi/amc/compose/entry/NaviAmcRouter.kt
View File

@@ -60,8 +60,6 @@ object NaviAmcRouter {
FtueFundSelectScreenDestination(
sourceScreen = bundle.getString(SOURCE).orEmpty()
)
NaviAmcScreen.AMC_GOAL_BASED_SIP_TARGET_SETUP_SCREEN.screenName ->
GoalBasedSipTargetSetupScreenDestination()
else -> {
null
}

2
android/navi-amc/src/main/java/com/navi/amc/compose/feature/goalBasedSip/viewmodel/GoalBasedSipSetupVM.kt
View File

@@ -40,7 +40,7 @@ class GoalBasedSipSetupVM @Inject constructor(private val repository: GoalBasedS
private val _showButtonLoader = MutableStateFlow(false)
val showButtonLoader = _showButtonLoader.asStateFlow()
private val _goalSummaryScreenData = SingleLiveEvent<GoalSummaryScreenData?>()
private val _goalSummaryScreenData = MutableLiveData<GoalSummaryScreenData?>()
val goalSummaryScreenData: LiveData<GoalSummaryScreenData?>
get() = _goalSummaryScreenData

4
android/navi-common/src/main/java/com/navi/common/utils/Constants.kt
View File

@@ -273,8 +273,8 @@ object Constants {
const val NULL_STRING_CAPS = "NULL"
const val AMC_GOAL_BASED_SIP_TARGET_SETUP_SCREEN =
"amc/goal/amc_goal_based_sip_target_setup_screen"
const val AMC_GOAL_BASED_SIP_AMOUNT_SCREEN = "amc/fund/goal_based_sip_amount_screen"
const val AMC_GOAL_BASED_SIP_SUMMARY_SCREEN = "amc/fund/goal_summary_screen"
const val AMC_GOAL_BASED_SIP_AMOUNT_SCREEN = "amc/fund/amc_goal_based_sip_amount_screen"
const val AMC_GOAL_BASED_SIP_SUMMARY_SCREEN = "amc/fund/amc_goal_based_sip_summary_screen"
/* Cta_Data */
const val KEY_CTA_DATA = "CtaData"