From d2ffb3e6eadfa52ca4474b49b66ea21f634d95e8 Mon Sep 17 00:00:00 2001 From: Varun Jain Date: Mon, 26 May 2025 15:26:24 +0530 Subject: [PATCH] NTP-67254 | Investments regression fixes (#16295) --- .../processHandlerImpl/HopperHelper.kt | 18 ++---------------- .../navi/amc/compose/entry/NaviAmcRouter.kt | 2 -- .../viewmodel/GoalBasedSipSetupVM.kt | 2 +- .../java/com/navi/common/utils/Constants.kt | 4 ++-- 4 files changed, 5 insertions(+), 21 deletions(-) diff --git a/android/app/src/main/java/com/naviapp/home/common/hopperProcessor/processHandlerImpl/HopperHelper.kt b/android/app/src/main/java/com/naviapp/home/common/hopperProcessor/processHandlerImpl/HopperHelper.kt index e060f7f1eb..f79e45c4b7 100644 --- a/android/app/src/main/java/com/naviapp/home/common/hopperProcessor/processHandlerImpl/HopperHelper.kt +++ b/android/app/src/main/java/com/naviapp/home/common/hopperProcessor/processHandlerImpl/HopperHelper.kt @@ -40,7 +40,6 @@ import com.navi.amc.utils.Constant.SIP_REFERENCE_ID import com.navi.analytics.utils.NaviTrackEvent import com.navi.base.model.CtaData import com.navi.common.utils.Constants.AMC_GOAL_BASED_SIP_AMOUNT_SCREEN -import com.navi.common.utils.Constants.AMC_GOAL_BASED_SIP_SUMMARY_SCREEN import com.navi.common.utils.Constants.AMC_GOAL_BASED_SIP_TARGET_SETUP_SCREEN import com.navi.common.utils.Constants.CTAData import com.navi.common.utils.Constants.HOPPER_API_RESPONSE_NOT_RECEIVED @@ -225,21 +224,8 @@ class HopperHelper { onResult, ) } - AMC_GOAL_BASED_SIP_SUMMARY_SCREEN -> { - viewModel.fetchGoalSummaryScreenDataFromRemote( - screenName = AMC_GOAL_BASED_SIP_SUMMARY_SCREEN, - goalReferenceId = - ctaData.parameters - ?.firstOrNull { it.key == GOAL_REFERENCE_ID } - ?.value - .orEmpty(), - ) - observeAndHandleResponse( - activity, - ctaData, - viewModel.goalSummaryScreenData, - onResult, - ) + else -> { + onResult(true) } } } diff --git a/android/navi-amc/src/main/java/com/navi/amc/compose/entry/NaviAmcRouter.kt b/android/navi-amc/src/main/java/com/navi/amc/compose/entry/NaviAmcRouter.kt index d63408d625..0e9c408cc8 100644 --- a/android/navi-amc/src/main/java/com/navi/amc/compose/entry/NaviAmcRouter.kt +++ b/android/navi-amc/src/main/java/com/navi/amc/compose/entry/NaviAmcRouter.kt @@ -60,8 +60,6 @@ object NaviAmcRouter { FtueFundSelectScreenDestination( sourceScreen = bundle.getString(SOURCE).orEmpty() ) - NaviAmcScreen.AMC_GOAL_BASED_SIP_TARGET_SETUP_SCREEN.screenName -> - GoalBasedSipTargetSetupScreenDestination() else -> { null } diff --git a/android/navi-amc/src/main/java/com/navi/amc/compose/feature/goalBasedSip/viewmodel/GoalBasedSipSetupVM.kt b/android/navi-amc/src/main/java/com/navi/amc/compose/feature/goalBasedSip/viewmodel/GoalBasedSipSetupVM.kt index 2fa4fb81b2..334de2495e 100644 --- a/android/navi-amc/src/main/java/com/navi/amc/compose/feature/goalBasedSip/viewmodel/GoalBasedSipSetupVM.kt +++ b/android/navi-amc/src/main/java/com/navi/amc/compose/feature/goalBasedSip/viewmodel/GoalBasedSipSetupVM.kt @@ -40,7 +40,7 @@ class GoalBasedSipSetupVM @Inject constructor(private val repository: GoalBasedS private val _showButtonLoader = MutableStateFlow(false) val showButtonLoader = _showButtonLoader.asStateFlow() - private val _goalSummaryScreenData = SingleLiveEvent() + private val _goalSummaryScreenData = MutableLiveData() val goalSummaryScreenData: LiveData get() = _goalSummaryScreenData diff --git a/android/navi-common/src/main/java/com/navi/common/utils/Constants.kt b/android/navi-common/src/main/java/com/navi/common/utils/Constants.kt index 634771b738..4263bba260 100644 --- a/android/navi-common/src/main/java/com/navi/common/utils/Constants.kt +++ b/android/navi-common/src/main/java/com/navi/common/utils/Constants.kt @@ -273,8 +273,8 @@ object Constants { const val NULL_STRING_CAPS = "NULL" const val AMC_GOAL_BASED_SIP_TARGET_SETUP_SCREEN = "amc/goal/amc_goal_based_sip_target_setup_screen" - const val AMC_GOAL_BASED_SIP_AMOUNT_SCREEN = "amc/fund/goal_based_sip_amount_screen" - const val AMC_GOAL_BASED_SIP_SUMMARY_SCREEN = "amc/fund/goal_summary_screen" + const val AMC_GOAL_BASED_SIP_AMOUNT_SCREEN = "amc/fund/amc_goal_based_sip_amount_screen" + const val AMC_GOAL_BASED_SIP_SUMMARY_SCREEN = "amc/fund/amc_goal_based_sip_summary_screen" /* Cta_Data */ const val KEY_CTA_DATA = "CtaData"