varnitgoyal95/super-app
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TP-65797 | Sidharth Bamba | issue fixes (#11061)

Browse Source 
Co-authored-by: Shaurya Rehan <shaurya.rehan@navi.com>
This commit is contained in:
Sidharth Bamba
2024-05-29 19:36:36 +05:30
committed by GitHub
parent a3ae8f3ff4
commit b6e5c3d822
3 changed files with 29 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/navi-bbps/src/main/kotlin/com/navi/bbps/feature/transactiondetails/BbpsEngagementBannerProvider.kt
View File

@@ -126,7 +126,7 @@ constructor(private val myBillsRepository: MyBillsRepository) {
),
EngagementBannerEntity(
categoryId = CATEGORY_ID_LPG_GAS,
title = "LPG Gas",
title = "LPG gas",
description = "Book your LPG gas cylinder directly from Navi",
ctaText = "Book now",
iconUrl =

50
android/navi-bbps/src/main/kotlin/com/navi/bbps/feature/transactiondetails/ui/BbpsPostPaymentScreen.kt
View File

@@ -520,7 +520,7 @@ private fun TransactionInfoCard(
Row(
modifier = Modifier.fillMaxWidth().padding(horizontal = 16.dp),
verticalAlignment = Alignment.CenterVertically
verticalAlignment = Alignment.Bottom
) {
Column(modifier = Modifier.weight(1f)) {
NaviText(
@@ -548,29 +548,32 @@ private fun TransactionInfoCard(
Spacer(modifier = Modifier.width(16.dp))
NaviText(
modifier =
Modifier.clickable(
interactionSource = remember { MutableInteractionSource() },
indication = rememberRipple(color = NaviBbpsColor.ctaPrimary)
) {
onCtaClicked.invoke()
}
.align(Alignment.Bottom),
text = stringResource(id = R.string.bbps_view_details),
fontFamily = ttComposeFontFamily,
fontWeight = getFontWeight(FontWeightEnum.NAVI_BODY_DEMI_BOLD),
fontSize = 14.sp,
color = transactionHistoryDetailItemProperty.bannerTextColor
)
Row(
Modifier.clickable(
interactionSource = remember { MutableInteractionSource() },
indication = rememberRipple(color = NaviBbpsColor.ctaPrimary)
) {
onCtaClicked.invoke()
}
.padding(start = 4.dp),
verticalAlignment = Alignment.CenterVertically
) {
NaviText(
text = stringResource(id = R.string.bbps_view_details),
fontFamily = ttComposeFontFamily,
fontWeight = getFontWeight(FontWeightEnum.NAVI_BODY_DEMI_BOLD),
fontSize = 14.sp,
color = transactionHistoryDetailItemProperty.bannerTextColor
)
Spacer(modifier = Modifier.width(2.dp))
Spacer(modifier = Modifier.width(2.dp))
Image(
modifier = Modifier.size(16.dp).align(Alignment.Bottom).padding(bottom = 2.dp),
painter = painterResource(id = R.drawable.ic_bbps_chevron_right),
contentDescription = ""
)
Image(
modifier = Modifier.size(16.dp),
painter = painterResource(id = R.drawable.ic_bbps_chevron_right),
contentDescription = ""
)
}
}
Spacer(modifier = Modifier.height(24.dp))
@@ -1138,7 +1141,8 @@ fun PaymentStatusDescription(billEntity: MyBillEntity) {
) {
Image(
painter = painterResource(id = R.drawable.ic_bbps_info_circle),
contentDescription = ""
contentDescription = "",
modifier = Modifier.size(16.dp)
)
Spacer(modifier = Modifier.width(12.dp))

2
android/navi-bbps/src/main/kotlin/com/navi/bbps/feature/transactiondetailsv2/ui/BbpsTransactionDetailsScreenV2.kt
View File

@@ -467,7 +467,7 @@ private fun ColumnScope.PaymentDetailsHiddenSection(
if (!transactionEntity?.transactionDetails?.bbpsTransactionId.isNullOrBlank()) {
KeyValueWithCopySection(
modifier = Modifier.fillMaxWidth().padding(horizontal = 16.dp),
key = stringResource(id = R.string.bbps_bbps_transaction_id),
key = stringResource(id = R.string.bbps_biller_reference_id),
value = transactionEntity?.transactionDetails?.bbpsTransactionId.orEmpty(),
iconId = R.drawable.ic_copy,
onCopyIconClicked = {