NTP-19547 | PS | fixed nps crash and added bu wise minappversion support (#14146)

android/navi-payment/src/main/java/com/navi/payment/nativepayment/sharedviewmodel/NaviCheckoutViewModel.kt

@@ -37,7 +37,7 @@ import com.navi.payment.network.util.PaymentsSdkRetrofit
 import com.navi.payment.paymentscreen.model.PMSErrorReason
 import com.navi.payment.paymentscreen.model.PaymentErrorData
 import com.navi.payment.utils.Constants
-import com.navi.payment.utils.Constants.DATA
+import com.navi.payment.utils.Constants.EXPERIMENT_DATA
 import com.navi.payment.utils.Constants.LITMUS_EXPERIMENT_NAVI_PMT_NPS_MIGRATION
 import com.navi.payment.utils.Constants.MIN_APP_VERSION
 import com.navi.payment.utils.getInstalledUpiApps
@@ -138,11 +138,12 @@ constructor(
                         ?.variant
                         ?.payload
                         ?.get("value") as? String)
-                    ?.let { JSONObject(it).optJSONObject(DATA) }
+                    ?.let { JSONObject(it).optJSONObject(EXPERIMENT_DATA) }
             val npsMigrationExperimentEnabled =
-                npsMigrationExperimentPayloadJson?.optBoolean(paymentSource).orFalse() &&
-                    npsMigrationExperimentPayloadJson?.optString(MIN_APP_VERSION).orEmpty() <=
-                        AppServiceManager.appVersionCode
+                npsMigrationExperimentPayloadJson
+                    ?.optJSONObject(paymentSource)
+                    ?.optString(MIN_APP_VERSION)
+                    ?.let { it <= AppServiceManager.appVersionCode } ?: false
             paymentDataProvider.add(
                 LITMUS_EXPERIMENT_NAVI_PMT_NPS_MIGRATION,
                 npsMigrationExperimentEnabled

android/navi-payment/src/main/java/com/navi/payment/nativepayment/viewmodel/NPSViewModel.kt

@@ -906,8 +906,8 @@ constructor(
             selectedBankAccount.isNotNull() ||
                 npsScreenState.naviUpiPaymentState.showOnboardingCard ||
                 (npsScreenState.naviUpiPaymentState.bankAccountState
-                        as BankAccountsState.AccountList)
-                    .accounts
+                        as? BankAccountsState.AccountList)
+                    ?.accounts
                     .isNotNullAndNotEmpty()
         ) {
             if (naviPayManager.isUserOnboarded().not()) {

android/navi-payment/src/main/java/com/navi/payment/utils/Constants.kt

@@ -133,6 +133,7 @@ object Constants {
 
     // Experiments
     const val LITMUS_EXPERIMENT_NAVI_PMT_NPS_MIGRATION = "navi-pmt-exp-nps-migration"
+    const val EXPERIMENT_DATA = "experiment_data"
     val PMS_LITMUS_EXPERIMENTS = listOf(LITMUS_EXPERIMENT_NAVI_PMT_NPS_MIGRATION)
 
     const val TRANSACTION_REFERENCE_ID = "transactionReferenceId"