varnitgoyal95/super-app
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #3836 from medici/revert-3832-bugfix_penny_drop

Browse Source 
Revert "Bugfix penny drop"
This commit is contained in:
Hitesh Kumar
2022-09-20 16:50:28 +05:30
committed by GitHub Enterprise
parent db07368da3 e29bebb61d
commit 6bb793dec1
4 changed files with 6 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/com/naviapp/homeloandigital/models/response/HomeLoanAutoDebitDetails.kt
View File

@@ -46,7 +46,6 @@ data class BankAccountDetails (
@SerializedName("accountNumber") val accountNumber: String? = null,
@SerializedName("bankName") val bankName: String? = null,
@SerializedName("status") val status: String? = null,
@SerializedName("source") val source: String? = null,
)
data class HomeLoanEmiDetail (

12
app/src/main/java/com/naviapp/homeloandigital/posteligibility/fragment/HomeLoanAutoDebitFragment.kt
View File

@@ -15,10 +15,11 @@ import android.view.View
import android.view.ViewGroup
import androidx.lifecycle.ViewModelProvider
import com.digio.`in`.esign2sdk.DigioResponseListener
import com.navi.base.model.CtaData
import com.navi.common.extensions.isNotNullAndNotEmpty
import com.navi.common.firebasedb.FirebaseStatusType
import com.navi.common.firebasedb.MANDATE
import com.navi.common.firebasedb.MANDATE_COMPLETE
import com.navi.base.model.CtaData
import com.navi.common.utils.*
import com.navi.naviwidgets.callbacks.WidgetCallback
import com.navi.naviwidgets.utils.setBackgroundColor
@@ -41,10 +42,9 @@ import com.naviapp.payment.models.ProviderType
import com.naviapp.personalloan.getloan.bankdetailsautodebit.viewmodels.EnachSharedVM
import com.naviapp.personalloan.getloan.helpers.EnachHelper
import com.naviapp.personalloan.getloan.helpers.EnachStub
import com.naviapp.utils.*
import com.naviapp.utils.Constants
import com.naviapp.utils.ifLet
import com.naviapp.utils.orValue
import com.naviapp.utils.setCornerRadius
import com.naviapp.utils.Constants.VERIFICATION_PENDING
import dagger.hilt.android.AndroidEntryPoint
@AndroidEntryPoint
@@ -98,7 +98,7 @@ class HomeLoanAutoDebitFragment : BaseHomeLoanFragment(), WidgetCallback,
response.content?.note?.iconCode
)
binding.bankVerifiedIv.setImageResource(
if (viewModel.shouldSetUpAutoPay())
if (response.content?.bankDetails?.status != VERIFICATION_PENDING && response.content?.bankDetails?.bankId.isNotNullAndNotEmpty())
R.drawable.ic_bank_verified
else
R.drawable.ic_bank_unverified
@@ -285,7 +285,7 @@ class HomeLoanAutoDebitFragment : BaseHomeLoanFragment(), WidgetCallback,
private fun setupAutoDebit() {
if (!isAdded && activity?.isFinishing.orTrue()) return
if (viewModel.shouldSetUpAutoPay()) {
if (viewModel.autoDebitDetails.value?.content?.bankDetails?.status != VERIFICATION_PENDING && viewModel.autoDebitDetails.value?.content?.bankDetails?.bankId.isNotNullAndNotEmpty()) {
naviAnalyticsEventTracker.onAutopayClicked()
showLoader()

11
app/src/main/java/com/naviapp/homeloandigital/posteligibility/viewmodel/HomeLoanAutoDebitFragmentVM.kt
View File

@@ -19,8 +19,6 @@ import com.naviapp.homeloandigital.posteligibility.repository.HomeLoanAutoDebitR
import com.naviapp.models.response.AdditionalDataAsyncResponse
import com.naviapp.models.response.AutoDebitMandateDetails
import com.naviapp.models.response.EnachMandateDetailsResponse
import com.naviapp.utils.Constants.APP
import com.naviapp.utils.Constants.VERIFICATION_PENDING
import dagger.hilt.android.lifecycle.HiltViewModel
import kotlinx.coroutines.launch
import javax.inject.Inject
@@ -101,15 +99,6 @@ class HomeLoanAutoDebitFragmentVM @Inject constructor(private val repository: Ho
}
}
fun shouldSetUpAutoPay(): Boolean {
autoDebitDetails.value?.content?.bankDetails?.let {
if (it.bankId.isNullOrEmpty()) return false
return ((it.source == APP) || (it.status == VERIFICATION_PENDING && it.source != APP) ||
(it.status.isNullOrEmpty() && (it.source.isNullOrEmpty())))
}
return false
}
fun deInitStopApiPolling() {
_stopApiPolling.value = null
}

1
app/src/main/java/com/naviapp/utils/Constants.kt
View File

@@ -270,7 +270,6 @@ object Constants {
const val BANK_ID = "bankId"
const val REQUEST_ID = "requestId"
const val VERIFICATION_PENDING = "PENDING"
const val APP = "APP"
const val MANDATE_CHANGE = "mandateChange"
const val AUTO_DEBIT_BACK = "AUTO_DEBIT_BACK"
const val CARD_GROUP_REFERENCE_ID = "cardGroupReferenceId"