NTP-77146 | bbps raamcosta add navigator crash fix (#16827)

This commit is contained in:
Mohit Rajput
2025-07-03 23:16:46 -07:00
committed by GitHub
parent b2b1ef2756
commit 5ee58535ea
2 changed files with 11 additions and 7 deletions

View File

@@ -82,7 +82,6 @@ class NaviBbpsActivity : BaseActivity(), BackButtonHandler {
NaviBbpsMainScreen(
naviBbpsActivity = this,
naviBbpsAnalytics = naviBbpsAnalytics,
naviBbpsMainViewModel = naviBbpsMainViewModel,
errorEventHandler = errorEventHandler,
onErrorVisibilityChange = { isErrorVisible, isErrorCancellable ->
isErrorSheetVisible = isErrorVisible

View File

@@ -52,12 +52,18 @@ fun NaviBbpsMainScreen(
naviBbpsActivity: NaviBbpsActivity,
errorEventHandler: ErrorEventHandler,
onErrorVisibilityChange: (IsErrorVisible, IsErrorCancellable) -> Unit,
naviBbpsMainViewModel: NaviBbpsMainViewModel,
naviBbpsAnalytics: NaviBbpsAnalytics.GenericDev,
) {
val bottomSheetNavigator = rememberBottomSheetNavigator()
val navController =
rememberNavController().apply { this.navigatorProvider += bottomSheetNavigator }
val navController = rememberNavController()
val navHostEngine = rememberNavHostEngine()
val isNavigatorAdded =
remember(key1 = navController, key2 = bottomSheetNavigator) {
navController.navigatorProvider.addNavigator(bottomSheetNavigator)
naviBbpsActivity.navController = navController
true // Return boolean indicating navigator was added
}
ModalBottomSheetLayout(
bottomSheetNavigator = bottomSheetNavigator,
@@ -67,15 +73,14 @@ fun NaviBbpsMainScreen(
rememberModalBottomSheetState(initialValue = ModalBottomSheetValue.Hidden),
sheetContent = {},
) {
naviBbpsActivity.navController = navController
DestinationsNavHost(
start =
NaviBbpsRouter.getStartDirection(
naviBbpsActivity.intent.getStringExtra(START_SCREEN_NAME) ?: EMPTY
),
navGraph = BbpsNavGraph,
engine = rememberNavHostEngine(),
navController = naviBbpsActivity.navController,
engine = navHostEngine,
navController = navController,
defaultTransitions = BbpsTransition,
dependenciesContainerBuilder = { dependency(naviBbpsActivity) },
)