TP-36523 | Increased Apk Size Diff Limit (#7329)
link: 'https://github.com/navi-android/super-app/pull/7329'
This commit is contained in:
committed by
GitHub
parent
658fa7d749
commit
1c952b6333
10
.github/workflows/generate_apk_diff.yml
vendored
10
.github/workflows/generate_apk_diff.yml
vendored
@@ -51,9 +51,9 @@ jobs:
|
||||
id: size-diff-check
|
||||
run: |
|
||||
size_diff=${{ steps.apk-diff.outputs.size_diff }}
|
||||
if [[ $size_diff -gt 71680 ]]; then
|
||||
if [[ $size_diff -gt 153600 ]]; then
|
||||
echo "::set-output name=job_status::failure"
|
||||
elif [[ $size_diff -gt 25600 ]]; then
|
||||
elif [[ $size_diff -gt 71680 ]]; then
|
||||
echo "::set-output name=job_status::warning"
|
||||
else
|
||||
echo "::set-output name=job_status::success"
|
||||
@@ -74,7 +74,7 @@ jobs:
|
||||
- Adding assets/resources: The addition of assets and resources can contribute to APK size growth.
|
||||
`;
|
||||
let comment;
|
||||
if (sizeDiffKB > 70) {
|
||||
if (sizeDiffKB > 150) {
|
||||
comment = `### :exclamation: APK Size Exceeded Limit
|
||||
The APK size has increased by ${sizeDiffKB} KB compared to the previous version. Please provide the reasons for this increase cc : ${codeOwnerTags}
|
||||
${additionalInfo}`;
|
||||
@@ -86,7 +86,7 @@ jobs:
|
||||
body: comment
|
||||
});
|
||||
|
||||
} else if (sizeDiffKB > 25) {
|
||||
} else if (sizeDiffKB > 70) {
|
||||
comment = `### :warning: APK Size Warning
|
||||
The APK size has increased by ${sizeDiffKB} KB compared to the previous version. Please provide the reasons for this increase cc : ${codeOwnerTags}
|
||||
${additionalInfo}`;
|
||||
@@ -103,6 +103,6 @@ jobs:
|
||||
run: |
|
||||
echo "Cleaning up..."
|
||||
rm -rf *.tmp
|
||||
- name: Fail Job if Size Diff Exceeds 70 KB
|
||||
- name: Fail Job if Size Diff Exceeds 150 KB
|
||||
if: ${{ steps.size-diff-check.outputs.job_status == 'failure' }}
|
||||
run: exit 1
|
||||
Reference in New Issue
Block a user