varnitgoyal95/super-app
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

error handling refactoring on kyc, pan (#856)

Browse Source
This commit is contained in:
Satish Prasad
2020-06-15 18:10:59 +05:30
committed by GitHub Enterprise
parent cab5b6e985
commit 1c7bf3ac6b
2 changed files with 19 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/com/naviapp/common/BaseVM.kt
View File

@@ -100,8 +100,8 @@ abstract class BaseVM : ViewModel() {
tag: String?,
cancelable: Boolean = true
) {
errors?.let {
setError(it, tag, cancelable)
if (errors?.size.orZero() > 0) {
setError(errors, tag, cancelable)
return
}
warning?.let {

55
app/src/main/java/com/naviapp/getloan/kyc/viewmodels/KycVM.kt
View File

@@ -87,11 +87,11 @@ class KycVM : BaseVM() {
if (response.error == null)
_selfieUploadAsyncData.value = response.data
else {
if (response.errors?.isNullOrEmpty().orTrue()) {
updateErrorMessage(response.error, ApiErrorTagType.SELFIE_UPLOAD)
} else {
setError(response.errors, ApiErrorTagType.SELFIE_UPLOAD)
}
setErrorData(
response.errors,
response.error,
ApiErrorTagType.SELFIE_UPLOAD
)
}
}
}
@@ -144,17 +144,7 @@ class KycVM : BaseVM() {
AADHAR_VERIFICATION -> ApiErrorTagType.AADHAAR_VERIFICATION_ASYNC_API_ERROR
else -> null
}
response.errors?.let {
setError(
response.errors,
errorTag
)
} ?: run {
updateErrorMessage(
response.error,
errorTag
)
}
setErrorData(response.errors, response.error, errorTag)
}
}
}
@@ -175,17 +165,11 @@ class KycVM : BaseVM() {
}
_digioConfig.value = data?.getDigioConfigData()
} else {
response.errors?.let {
setError(
response.errors,
ApiErrorTagType.INIT_AADHAAR_VERIFICATION_API_ERROR
)
} ?: run {
updateErrorMessage(
response.error,
ApiErrorTagType.INIT_AADHAAR_VERIFICATION_API_ERROR
)
}
setErrorData(
response.errors,
response.error,
ApiErrorTagType.INIT_AADHAAR_VERIFICATION_API_ERROR
)
}
}
}
@@ -233,17 +217,12 @@ class KycVM : BaseVM() {
if (response.error == null) {
_aadharVerificationStatusResponse.value = response.data
} else {
response.errors?.let {
setError(
response.errors,
ApiErrorTagType.AADHAAR_STATUS_VERIFICATION_API_ERROR, false
)
} ?: run {
updateErrorMessage(
response.error,
ApiErrorTagType.AADHAAR_STATUS_VERIFICATION_API_ERROR, false
)
}
setErrorData(
response.errors,
response.error,
ApiErrorTagType.AADHAAR_STATUS_VERIFICATION_API_ERROR,
false
)
}
}
}