varnitgoyal95/super-app
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

NTP-7772 | KYC Incident | Cache API OnCreate | Policy Details Screen UI Fix (#13528)

Browse Source
This commit is contained in:
Prajjaval Verma
2024-11-09 01:39:11 +05:30
committed by GitHub
parent d2031c971f
commit 179801df8c
7 changed files with 31 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
App/Container/Navi-Insurance/network/BenefitPageApi.ts
View File

@@ -68,7 +68,7 @@ export const getBenefitPageData = async (
properties: {
methodName: AnalyticsFlowNameConstant.GI_RN_BENEFIT,
reason: `${error.message}, axiosError: ${error.axiosCode}`,
statusCode: error.statusCode,
statusCode: error.statusCode.toString(),
},
});
}

2
App/Container/Navi-Insurance/network/MarketBenefitComparePageApi.ts
View File

@@ -64,7 +64,7 @@ export const getMarketBenefitComparePageData = async (
properties: {
methodName: AnalyticsFlowNameConstant.GI_RN_BENEFIT_COMPARE,
reason: `${error.message}, axiosError: ${error.axiosCode}`,
statusCode: error.statusCode,
statusCode: error.statusCode.toString(),
},
});
}

2
App/Container/Navi-Insurance/network/WaitingPeriodApi.ts
View File

@@ -64,7 +64,7 @@ export const getWaitingPeriodScreenData = async (
properties: {
methodName: AnalyticsFlowNameConstant.GI_WAITING_PERIOD,
reason: `${error.message}, axiosError: ${error.axiosCode}`,
statusCode: error.statusCode,
statusCode: error.statusCode.toString(),
},
});
}

4
android/app/src/main/java/com/naviapp/home/dashboard/ui/compose/insuranceTab/InitScreenLifeCycleListener.kt
View File

@@ -23,9 +23,11 @@ fun InitScreenLifeCycleListener(activity: HomePageActivity, viewmodel: Insurance
DisposableEffect(key1 = lifecycleOwner) {
val observer = LifecycleEventObserver { _, event ->
when (event) {
Lifecycle.Event.ON_CREATE -> {
viewmodel.clearCacheOnVersionUpgrade()
}
Lifecycle.Event.ON_RESUME -> {
viewmodel.fetchInsuranceTabDetails()
viewmodel.clearCacheOnVersionUpgrade()
viewmodel.observeCtaData(
viewmodel = viewmodel,
activity = activity,

1
android/navi-insurance/src/main/java/com/navi/insurance/kyc/ui/GiAadhaarVerificationFragment.kt
View File

@@ -423,6 +423,7 @@ class GiAadhaarVerificationFragment : GiBaseFragment(), OKYCListener {
analyticsEventTracker.okycFailed(
mapOf(
Pair("error_code", error.errorCode.toString()),
Pair("message", error.message.toString()),
Pair("error_message", error.errorMessage),
Pair("screen", screenName)
)

14
android/navi-insurance/src/main/java/com/navi/insurance/policy/details/PolicyDetailsFragment.kt
View File

@@ -116,17 +116,25 @@ class PolicyDetailsFragment : BaseFragment(), WidgetCallback {
modifier = Modifier.fillMaxSize().background(color = Color.White),
topBar = {
data.headerNativeWidget?.getOrNull(0)?.let { data ->
GenericComposableWidgetFactory(data = data, this, isFirstItemVisible)
Box(modifier = Modifier.background(color = Color.White)) {
GenericComposableWidgetFactory(
data = data,
this@PolicyDetailsFragment,
isFirstItemVisible
)
}
}
},
bottomBar = {
data.footerNativeWidget?.getOrNull(0)?.let { data ->
GenericComposableWidgetFactory(data = data, this)
Box(modifier = Modifier.background(color = Color.White)) {
GenericComposableWidgetFactory(data = data, this@PolicyDetailsFragment)
}
}
}
) { paddingValues ->
CompositionLocalProvider(LocalOverscrollConfiguration provides null) {
Box(modifier = Modifier.padding(paddingValues)) {
Box(modifier = Modifier.padding(paddingValues).background(color = Color.White)) {
LazyColumn(
modifier = Modifier.fillMaxWidth().wrapContentHeight(),
state = listState

17
android/navi-widgets/src/main/java/com/navi/naviwidgets/composewidget/widgets/FooterWithCardAndSnackBarWidgetComposable.kt
View File

@@ -26,7 +26,6 @@ import com.navi.naviwidgets.callbacks.WidgetCallback
import com.navi.naviwidgets.composewidget.reusable.FooterButtonComposable
import com.navi.naviwidgets.composewidget.reusable.FooterCardComposable
import com.navi.naviwidgets.composewidget.reusable.FooterSnackbarComposable
import com.navi.naviwidgets.composewidget.reusable.colorShadow
import com.navi.naviwidgets.composewidget.reusable.whiteColor
import com.navi.naviwidgets.extensions.NaviTextWidgetized
import com.navi.naviwidgets.models.FooterButtonState
@@ -53,15 +52,25 @@ fun FooterWithCardAndSnackBarWidgetComposable(
FooterSnackbarComposable(data = data.footerWithCardAndSnackbarWidgetBody?.snackBarInfo)
Column(modifier = Modifier.fillMaxWidth()) {
if (
data.footerWithCardAndSnackbarWidgetBody?.cardInfo.isNotNull() ||
data.footerWithCardAndSnackbarWidgetBody?.errorCardInfo.isNotNull()
(data.footerWithCardAndSnackbarWidgetBody?.cardInfo.isNotNull() ||
data.footerWithCardAndSnackbarWidgetBody?.errorCardInfo.isNotNull()) &&
(data.footerWithCardAndSnackbarWidgetBody
?.footerButton
?.title
?.text
.isNotNull() ||
data.footerWithCardAndSnackbarWidgetBody
?.secondaryFooterButton
?.title
?.text
.isNotNull())
) {
Box(
modifier =
Modifier.background(
brush =
Brush.verticalGradient(
colors = listOf(Color.Transparent, colorShadow)
colors = listOf(Color.Transparent, Color.LightGray)
),
shape = RoundedCornerShape(topStart = 16.dp, topEnd = 16.dp)
)