varnitgoyal95/super-app
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TP-53325 | Fix | Design Feedback (#9228)

Browse Source
This commit is contained in:
Kshitij Pramod Ghongadi
2024-01-05 11:21:44 +05:30
committed by GitHub
parent 375f32762a
commit 00f4392940
8 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
navi-insurance/src/main/java/com/navi/insurance/common/bottom_sheet/TIExplainerBottomSheet.kt
View File

@@ -40,6 +40,7 @@ import com.navi.insurance.common.models.TIExplainerBottomSheetData
import com.navi.insurance.databinding.LayoutClaimsStepsBottomSheetBinding
import com.navi.insurance.navigator.NaviInsuranceDeeplinkNavigator
import com.navi.insurance.pre.purchase.journey.FooterButtonState
import com.navi.insurance.pre.purchase.journey.colorTextSecondary
import com.navi.insurance.pre.purchase.journey.composables.reusable.FooterButtonComposable
import com.navi.insurance.util.CONTENT_DATA_JSON_STRING
import com.navi.insurance.util.Constants
@@ -145,7 +146,7 @@ class TIExplainerBottomSheet : BaseBottomSheet(), WidgetCallback {
)
}
}
Spacer(modifier = Modifier.height(16.dp))
StepsComposable(
modifier = Modifier
.fillMaxWidth()
@@ -157,6 +158,19 @@ class TIExplainerBottomSheet : BaseBottomSheet(), WidgetCallback {
footerButton?.let {
Spacer(modifier = Modifier.height(36.dp))
NaviText(textFieldData = data.rewardBannerData, modifier = Modifier
.fillMaxWidth()
.padding(bottom = 4.dp))
if (data.showDivider == true) {
DashedDivider(
thicknessInDp = 2.dp,
color = colorTextSecondary,
modifier = Modifier
.fillMaxWidth()
.height(2.dp)
.padding(horizontal = 16.dp, vertical = 12.dp)
)
}
FooterButtonComposable(
data = it,
state = FooterButtonState.ENABLED.name,
@@ -180,7 +194,7 @@ class TIExplainerBottomSheet : BaseBottomSheet(), WidgetCallback {
NaviText(textFieldData = stepsData.title, modifier = Modifier.wrapContentSize())
Spacer(modifier = Modifier.height(34.dp))
Spacer(modifier = Modifier.height(32.dp))
stepsData.steps?.let { stepsContent ->
val totalItems = stepsContent.size

4
navi-insurance/src/main/java/com/navi/insurance/common/models/TIExplainerBottomSheetData.kt
View File

@@ -8,7 +8,9 @@ import com.navi.naviwidgets.models.response.TitleSubtitleImageWidgetBody
data class TIExplainerBottomSheetData(
@SerializedName("headerContent") val headerContent: TitleSubtitleImageWidgetBody? = null,
@SerializedName("stepsContent") val stepsContent: StepsContentData? = null,
@SerializedName("footerButton") val footerButton: FooterButtonData? = null
@SerializedName("footerButton") val footerButton: FooterButtonData? = null,
@SerializedName("rewardBannerData") val rewardBannerData : TextFieldData? = null,
@SerializedName("showDivider") val showDivider: Boolean? = null,
) {
data class StepsContentData(
@SerializedName("title") val title: TextFieldData? = null,

2
navi-insurance/src/main/java/com/navi/insurance/new_hospital_experience/fragment/GiNewHospitalsFragment.kt
View File

@@ -70,11 +70,9 @@ class GiNewHospitalsFragment : GiBaseFragment(), WidgetCallback {
ctaData.parameters?.forEach {
if (it.key == KEY_BOTTOM_SHEET_EXPANDED) {
viewModel.setBottomSheetExpandeddata(it.value.toBoolean())
return
}
if (it.key == KEY_SHOW_FOOTER) {
viewModel.setFooterVisibility(it.value.toBoolean().orTrue())
return
}
}

2
navi-insurance/src/main/java/com/navi/insurance/new_hospital_experience/view/HospitalPageComposable.kt
View File

@@ -309,7 +309,7 @@ fun HospitalPageComposable(
}, bottomBar = {
//This bottom sticky footer button might change in the next variant
((pageResponseState.value as? ResponseState.Success)?.value?.topPageData)?.let {
if (!viewModel.isBottomsheetExpanded && viewModel.shouldShowFooter) {
if (viewModel.shouldShowFooter) {
HospitalFooterButtonComposable(
hospitalTopPageData = it, widgetCallback = widgetCallback
)

2
navi-insurance/src/main/java/com/navi/insurance/new_hospital_experience/view/LocationPageComposable.kt
View File

@@ -144,7 +144,7 @@ fun LocationPageComposable(
.background(color = Color.Transparent)
)
Image(
painter = painterResource(id = R.drawable.ic_back_arrow_with_tail),
painter = painterResource(id = R.drawable.ic_back_arrow_with_padding),
contentDescription = "back arrow",
modifier = Modifier
.padding(start = 16.dp, top = 8.dp)

1
navi-insurance/src/main/res/layout/quote_footer_view.xml
View File

@@ -162,6 +162,7 @@
android:layout_height="@dimen/dp_48"
android:layout_gravity="center_vertical|end"
android:layout_marginHorizontal="@dimen/dp_8"
android:fontFamily="@font/tt_semi_bold"
android:text="@{quoteFooterInfoModel.cta.title != null ? quoteFooterInfoModel.cta.title : @string/text_continue }"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"

2
navi-widgets/src/main/res/layout/layout_check_box_radio_button_card_item.xml
View File

@@ -37,7 +37,7 @@
android:layout_width="@dimen/dp_0"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/dp_16"
android:layout_marginTop="@dimen/dp_24"
android:layout_marginTop="@dimen/dp_26"
android:paddingBottom="@dimen/dp_8"
android:layout_marginEnd="@dimen/dp_12"
android:fontFamily="@font/tt_regular"

2
navi-widgets/src/main/res/layout/layout_separate_card_with_card_list.xml
View File

@@ -60,7 +60,7 @@
style="@style/Small_SemiBold_Dark_gray"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/dp_16"
android:layout_marginTop="@dimen/dp_12"
android:fontFamily="@font/tt_regular"
android:paddingHorizontal="@dimen/dp_8"
android:paddingVertical="@dimen/dp_4"