varnitgoyal95/super-app
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

NTP-74530 | update NAE logic in bill actions api (#16649)

Browse Source
This commit is contained in:
Abhinav Gupta
2025-06-19 14:27:32 +05:30
committed by GitHub
parent ecabe7d514
commit 00928d3592
3 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/billcalendar/data/analytics/BillCalendarAnalytics.kt
View File

@@ -101,6 +101,7 @@ interface AddBillScreenEventTracker :
@EventName("mm_add_bill_footer_button_clicked")
fun onAddBillFooterButtonClicked(
billId: String,
billName: String,
billAmount: String,
billSelectedDate: String,

16
android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/billcalendar/presentation/ui/screen/AddBillScreen.kt
View File

@@ -111,10 +111,14 @@ fun AddNewBillScreen(
AddBillScreenTopBar(
navBarData = navBarData,
onHelpClick = {
eventTracker.onAddBillScreenHelpClicked()
focusManager.clearFocus()
viewModel.setEffect { AddNewBillUiEffect.Navigation.Help }
},
onBackClick = { viewModel.setEffect { AddNewBillUiEffect.Navigation.Back } },
onBackClick = {
eventTracker.onAddBillScreenBackClicked()
viewModel.setEffect { AddNewBillUiEffect.Navigation.Back }
},
)
}
},
@@ -127,6 +131,13 @@ fun AddNewBillScreen(
billId?.let {
viewModel.submitBill(actionType = BillActionType.EDIT, billId = it)
} ?: run { viewModel.submitBill(actionType = BillActionType.ADD) }
eventTracker.onAddBillFooterButtonClicked(
billId = billId.orEmpty(),
billName = data.data?.content?.billName?.text.orEmpty(),
billAmount = data.data?.content?.billAmount?.text.orEmpty(),
billSelectedDate = data.data?.content?.billSelectedDate.orEmpty(),
billFrequency = data.data?.content?.billFrequency.orEmpty(),
)
},
)
}
@@ -148,6 +159,7 @@ fun AddNewBillScreen(
viewModel.onBillAmountChanged(billAmount)
},
onSelectBillFrequencyIconClick = {
eventTracker.onAddBillFrequencySectionClicked()
focusManager.clearFocus()
viewModel.sendEvent(
AddBillUiEvent.ShowBottomSheet(
@@ -156,10 +168,12 @@ fun AddNewBillScreen(
)
},
onDatePickerIconClick = {
eventTracker.onAddBillSelectDateSectionClicked()
focusManager.clearFocus()
viewModel.sendEvent(AddBillUiEvent.ShowDatePickerDialog)
},
onEditIconClick = {
eventTracker.onAddBillIconClicked()
focusManager.clearFocus()
viewModel.getSelectBillIconBottomSheetData()
},

8
android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/common/dataprovider/data/remote/RemoteDataProviderImpl.kt
View File

@@ -242,7 +242,7 @@ class RemoteDataProviderImpl @Inject constructor(private val retrofitService: Re
metricInfo =
MetricInfo.AppMetric(
screen = MMScreen.BILL_CALENDAR_SCREEN.screen,
isNae = { true },
isNae = { !it.isSuccessWithData() },
),
)
}
@@ -253,7 +253,7 @@ class RemoteDataProviderImpl @Inject constructor(private val retrofitService: Re
metricInfo =
MetricInfo.AppMetric(
screen = MMScreen.BILL_CALENDAR_SCREEN.screen,
isNae = { true },
isNae = { !it.isSuccessWithData() },
),
)
}
@@ -266,7 +266,7 @@ class RemoteDataProviderImpl @Inject constructor(private val retrofitService: Re
metricInfo =
MetricInfo.AppMetric(
screen = MMScreen.BILL_CALENDAR_SCREEN.screen,
isNae = { true },
isNae = { !it.isSuccessWithData() },
),
)
}
@@ -280,7 +280,7 @@ class RemoteDataProviderImpl @Inject constructor(private val retrofitService: Re
metricInfo =
MetricInfo.AppMetric(
screen = MMScreen.BILL_CALENDAR_SCREEN.screen,
isNae = { true },
isNae = { !it.isSuccessWithData() },
),
)
}