varnitgoyal95/litmus-fe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TP-17651 | Bug Fixes for metrics

Browse Source
This commit is contained in:
yashmantri
2023-05-08 16:26:00 +05:30
parent 6d0e01252b
commit 548769fd51
4 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/pages/EditExperiment/EditExperiment.module.scss
View File

@@ -60,7 +60,6 @@
display: flex;
align-items: center;
padding: 0 8px;
margin-left: 13px;
border-radius: 4px;
font-size: 12px;
color: #657384;

6
src/pages/EditExperiment/ExperimentDetails/Overview/GuardRailMetricTable.tsx
View File

@@ -10,13 +10,13 @@ const GuardRailMetricTable = () => {
const { updateExperiment } = useAppSelector(
(state) => state.litmusFormDataStore,
);
const { overviewData, visitorsData } = updateExperiment || {};
const { overviewData, variants } = updateExperiment || {};
const guardRailMetricsData = overviewData?.filter(
(metric) => metric?.experimentMetricType === MetricLabel.GUARDRAIL,
);
const variants = getVariantsName(visitorsData);
const variantsData = getVariantsName(variants);
const columnDefs = [
{
@@ -37,7 +37,7 @@ const GuardRailMetricTable = () => {
<Typography variant="p3">{params.value?.toFixed(2)}%</Typography>
),
},
...variants.map((item: any, index: number) => {
...variantsData.map((item: any, index: number) => {
return {
headerName: item.name,
field: item.name,

6
src/pages/EditExperiment/ExperimentDetails/Overview/PrimaryMetricTable.tsx
View File

@@ -10,13 +10,13 @@ const PrimaryMetricTable = () => {
const { updateExperiment } = useAppSelector(
(state) => state.litmusFormDataStore,
);
const { overviewData, visitorsData } = updateExperiment || {};
const { overviewData, variants } = updateExperiment || {};
const primaryMetricsData = overviewData?.filter(
(metric) => metric?.experimentMetricType === MetricLabel.PRIMARY,
);
const variants = getVariantsName(visitorsData);
const variantsData = getVariantsName(variants);
const columnDefs = [
{
headerName: 'Metrics',
@@ -36,7 +36,7 @@ const PrimaryMetricTable = () => {
<Typography variant="p3">{params.value?.toFixed(2)}%</Typography>
),
},
...variants.map((item: any, index: number) => {
...variantsData.map((item: any, index: number) => {
return {
headerName: item.name,
field: item.name,

6
src/pages/EditExperiment/ExperimentDetails/Overview/SecondaryMetricTable.tsx
View File

@@ -18,7 +18,7 @@ const SecondaryMetricTable = () => {
const { permissions } = authData || {};
const isUpdatedAllowed = checkLitmusWritePermission(permissions);
const { overviewData, visitorsData, experimentInfo } = updateExperiment || {};
const { overviewData, experimentInfo, variants } = updateExperiment || {};
const { experimentStatus } = experimentInfo || {};
@@ -26,7 +26,7 @@ const SecondaryMetricTable = () => {
(metric) => metric?.experimentMetricType === MetricLabel.SECONDARY,
);
const variants = getVariantsName(visitorsData);
const variantsData = getVariantsName(variants);
const columnDefs = [
{
@@ -47,7 +47,7 @@ const SecondaryMetricTable = () => {
<Typography variant="p3">{params.value?.toFixed(2)}%</Typography>
),
},
...variants.map((item: any, index: number) => {
...variantsData.map((item: any, index: number) => {
return {
headerName: item.name,
field: item.name,