varnitgoyal95/litmus-be
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

resolve https://github.cmd.navi-tech.in/medici/litmus/pull/33#discussion_r95054

Browse Source
This commit is contained in:
akshat-sonic
2023-02-22 13:00:33 +05:30
parent ca5c6187b0
commit f992c98f91
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
litmus-core/src/main/java/com/navi/medici/controller/v1/MetricController.java
View File

@@ -22,8 +22,8 @@ public class MetricController {
@PostMapping
@Timed(value = "litmus.create.metric", percentiles = {0.95, 0.99})
public ResponseEntity<MetricResponse> createMetric(@RequestBody CreateMetricRequest createMetricRequest, @RequestHeader("x-session-token") String sessionToken){
public ResponseEntity<MetricResponse> createMetric(@RequestBody CreateMetricRequest createMetricRequest, @RequestHeader("x-email-id") String emailId){
log.info("create request received for creating metric : {}", createMetricRequest.getMetricName());
return ResponseEntity.ok(metricService.createMetric(createMetricRequest,sessionToken));
return ResponseEntity.ok(metricService.createMetric(createMetricRequest,emailId));
}
}

1
litmus-core/src/main/java/com/navi/medici/request/CreateMetricRequest.java
View File

@@ -17,5 +17,4 @@ public class CreateMetricRequest {
String metricName;
String athenaQuery;
MetricType metricType;
String createdBy;
}

4
litmus-core/src/main/java/com/navi/medici/service/metric/MetricServiceImpl.java
View File

@@ -24,13 +24,13 @@ public class MetricServiceImpl implements MetricService {
private final JacksonUtils jacksonUtils;
private final MetricValidator metricRequestValidator;
@Override
public MetricResponse createMetric(CreateMetricRequest createMetricRequest, String sessionToken) {
public MetricResponse createMetric(CreateMetricRequest createMetricRequest, String emailId) {
metricRequestValidator.validateCreateMetricRequest(createMetricRequest);
MetricEntity metric = MetricEntity.builder()
.metricId(UUID.randomUUID().toString())
.metricName(createMetricRequest.getMetricName())
.metricType(jacksonUtils.objectToString(createMetricRequest.getMetricType()))
.createdBy(createMetricRequest.getCreatedBy())
.createdBy(emailId)
.athenaQuery(createMetricRequest.getAthenaQuery())
.build();
return metricMapper.mapMetricEntityToMetricResponse(metricRepository.save(metric));