varnitgoyal95/litmus-be
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Akshat | TP-12345 | add index on experiments(enabled) (#52)

Browse Source 
* TP-12345 | add index on experiments(enabled)

* TP-12345 | add group id when updating strategies

* TP-12345 | vertical should be equal to teamName
This commit is contained in:
Akshat Soni
2023-04-11 20:33:17 +05:30
committed by GitHub Enterprise
parent ea44f632d6
commit 0c5830db16
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
litmus-core/src/main/java/com/navi/medici/service/experiment/ExperimentServiceImpl.java
View File

@@ -111,7 +111,7 @@ public class ExperimentServiceImpl implements ExperimentService {
.strategies(jacksonUtils.objectToString(strategies))
.variants(jacksonUtils.objectToString(variants))
.type(ExperimentType.EXPERIMENT)
.vertical(request.getVertical())
.vertical(team.map(TeamEntity::getTeamName).orElse(null))
.createdBy(emailId)
.build();
Optional<MetricEntity> primaryMetric = metricQuery.findByMetricName(request.getPrimaryMetric());
@@ -261,7 +261,19 @@ public class ExperimentServiceImpl implements ExperimentService {
throw new LitmusExperimentNotFoundException(String.format("experiment %s not found in system",
litmusExperimentStrategyUpdate.getExperimentId()));
}
litmusExperimentStrategyUpdate.getStrategies().forEach(
strategy -> {
Map<String, String> parameters = new HashMap<>(strategy.getParameters());
if (StringUtils.isBlank(strategy.getParameters().get("groupId"))) {
if (strategy.getName().equals("flexibleRollout")) {
parameters.put("groupId", experimentExist.get().getName() + "-group-id");
} else {
parameters.put("groupId", strategy.getParameters().get("segment") + "-group-id");
}
}
strategy.setParameters(parameters);
}
);
log.info("updating strategies. experiment: {}, new_strategies: {}, old_strategies:{}",
experimentExist.get().getName(),
jacksonUtils.objectToString(litmusExperimentStrategyUpdate.getStrategies()),

4
litmus-liquibase/src/main/resources/db/changelog/202304111312-add-index-on-enabled.sql Normal file
View File

@@ -0,0 +1,4 @@
--liquibase formatted sql
--changeset author:akshatsoni id:202304111312
CREATE INDEX idx_enabled on experiments (enabled);