Merge pull request #201 from navi-infra/INFRA-3131

INFRA-3131 | Ankit Bhardwaj | add rds total iops alerts

config/prod/default.yml

@@ -1,2 +1,2 @@
 app_name: infra-provisioner-v2
-version: v2.47.2
+version: v2.48.0

templates/rds-tf/main.tf

@@ -212,6 +212,10 @@ module "rds" {
   ebs_io_balance_alarm_threshold = {{ .ExtraResources.Database.RdsAlertThresholds.EBSIOBalance | quote }}
   {{- end }}
 
+  {{- if .ExtraResources.Database.RdsAlertThresholds.TotalIOPS }}
+  total_iops_alarm_threshold  = {{ .ExtraResources.Database.RdsAlertThresholds.TotalIOPS | quote }}
+  {{- end }}
+
   {{- end }}
 
   {{- if .ExtraResources.Database.RdsAlertDurations }}
@@ -260,6 +264,10 @@ module "rds" {
   ebs_io_balance_alarm_evaluation_period = {{ .ExtraResources.Database.RdsAlertDurations.EBSIOBalance | quote }}
   {{- end }}
 
+  {{- if .ExtraResources.Database.RdsAlertDurations.TotalIOPS }}
+  total_iops_alarm_evaluation_period = {{ .ExtraResources.Database.RdsAlertDurations.TotalIOPS | quote }}
+  {{- end }}
+
   {{- end }}
 
   {{- if .ExtraResources.Database.StorageEncrypted }}

testdata/expected_output/sample_infra_manifest/rds-tf/main.tf

@@ -66,6 +66,7 @@ module "rds" {
   write_latency_alarm_threshold = "0.5"
   ebs_byte_balance_alarm_threshold = "70"
   ebs_io_balance_alarm_threshold = "70"
+  total_iops_alarm_threshold  = "80"
   cpu_utilization_alarm_evaluation_period = "15"
   cpucredit_balance_alarm_evaluation_period = "5"
   burst_balance_alarm_evaluation_period = "5"
@@ -77,6 +78,7 @@ module "rds" {
   write_latency_alarm_evaluation_period = "5"
   ebs_byte_balance_alarm_evaluation_period = "5"
   ebs_io_balance_alarm_evaluation_period = "5"
+  total_iops_alarm_evaluation_period = "10"
   storage_encrypted = false
 
 }

testdata/sample_infra_manifest.json

@@ -49,7 +49,8 @@
         "readLatency": 0.5,
         "writeLatency": 0.5,
         "ebsByteBalance": 70,
-        "ebsIOBalance": 70
+        "ebsIOBalance": 70,
+        "totalIOPS": 80
       },
       "rdsAlertDurations": {
         "cpuUtilization": 15,
@@ -62,7 +63,8 @@
         "readLatency": 5,
         "writeLatency": 5,
         "ebsByteBalance": 5,
-        "ebsIOBalance": 5
+        "ebsIOBalance": 5,
+        "totalIOPS": 10
       }
     },
     "docdb": {

types.go

@@ -281,6 +281,7 @@ type RdsAlertThresholds struct {
 	WriteLatency            float64 `json:"writeLatency"`
 	EBSByteBalance          int     `json:"ebsByteBalance"`
 	EBSIOBalance            int     `json:"ebsIOBalance"`
+	TotalIOPS               int     `json:"totalIOPS" `
 }
 
 type RdsAlertDurations struct {
@@ -295,6 +296,7 @@ type RdsAlertDurations struct {
 	WriteLatency            int `json:"writeLatency"`
 	EBSByteBalance          int `json:"ebsByteBalance"`
 	EBSIOBalance            int `json:"ebsIOBalance"`
+	TotalIOPS               int `json:"totalIOPS"`
 }
 
 type AuroraAlertThresholds struct {