TP-25848 | shifting unnecessary logic of changing severity to async func (#99)
This commit is contained in:
committed by
GitHub Enterprise
parent
843da0616e
commit
8aa4cd4350
@@ -96,42 +96,42 @@ func (isp *IncidentUpdateSevertityAction) IncidentUpdateSeverity(callback slack.
|
||||
for _, o := range incidentSeverityEntity.SlackUserIds {
|
||||
isp.slackbotClient.InviteUsersToConversation(callback.View.PrivateMetadata, o)
|
||||
}
|
||||
go func() {
|
||||
msgOption := slack.MsgOptionText(fmt.Sprintf("<@%s> *>* `set severity to %s (%s)`", user.ID, incidentSeverityEntity.Name, incidentSeverityEntity.Description), false)
|
||||
_, _, errMessage := isp.client.PostMessage(callback.View.PrivateMetadata, msgOption)
|
||||
if errMessage != nil {
|
||||
isp.logger.Error("post response failed for IncidentUpdateSeverity", zap.Error(errMessage))
|
||||
return
|
||||
}
|
||||
|
||||
msgOption := slack.MsgOptionText(fmt.Sprintf("<@%s> *>* `set severity to %s (%s)`", user.ID, incidentSeverityEntity.Name, incidentSeverityEntity.Description), false)
|
||||
_, _, errMessage := isp.client.PostMessage(callback.View.PrivateMetadata, msgOption)
|
||||
if errMessage != nil {
|
||||
isp.logger.Error("post response failed for IncidentUpdateSeverity", zap.Error(errMessage))
|
||||
return
|
||||
}
|
||||
teamEntity, err := isp.teamService.FindTeamById(incidentEntity.TeamId)
|
||||
if err != nil {
|
||||
isp.logger.Error("FindTeamEntityById error",
|
||||
zap.String("incident_slack_channel_id", channel.ID), zap.String("channel", channel.Name),
|
||||
zap.String("user_id", user.ID), zap.Error(err))
|
||||
return
|
||||
} else if teamEntity == nil {
|
||||
isp.logger.Error("Team Not Found",
|
||||
zap.String("incident_slack_channel_id", channel.ID), zap.String("channel", channel.Name),
|
||||
zap.String("user_id", user.ID), zap.Error(err))
|
||||
return
|
||||
}
|
||||
|
||||
teamEntity, err := isp.teamService.FindTeamById(incidentEntity.TeamId)
|
||||
if err != nil {
|
||||
isp.logger.Error("FindTeamEntityById error",
|
||||
zap.String("incident_slack_channel_id", channel.ID), zap.String("channel", channel.Name),
|
||||
zap.String("user_id", user.ID), zap.Error(err))
|
||||
return
|
||||
} else if teamEntity == nil {
|
||||
isp.logger.Error("Team Not Found",
|
||||
zap.String("incident_slack_channel_id", channel.ID), zap.String("channel", channel.Name),
|
||||
zap.String("user_id", user.ID), zap.Error(err))
|
||||
return
|
||||
}
|
||||
|
||||
txt := fmt.Sprintf("set the channel topic: *%s · %s (%s) %s* | %s", teamEntity.Name, incidentSeverityEntity.Name, incidentSeverityEntity.Description, incidentEntity.IncidentName, incidentEntity.Title)
|
||||
att := slack.Attachment{
|
||||
Text: txt,
|
||||
Color: "#808080", // Grey color code
|
||||
MarkdownIn: []string{"txt"}, // Define which fields support markdown
|
||||
}
|
||||
_, _, errMessage = isp.client.PostMessage(callback.View.PrivateMetadata, slack.MsgOptionAttachments(att))
|
||||
if errMessage != nil {
|
||||
isp.logger.Error("post response failed for IncidentUpdateType", zap.Error(errMessage))
|
||||
return
|
||||
}
|
||||
|
||||
topic := fmt.Sprintf("%s-%s(%s) Incident-%d | %s", teamEntity.Name, incidentSeverityEntity.Name, incidentSeverityEntity.Description, incidentEntity.ID, incidentEntity.Title)
|
||||
isp.slackbotClient.SetChannelTopic(callback.View.PrivateMetadata, topic)
|
||||
txt := fmt.Sprintf("set the channel topic: *%s · %s (%s) %s* | %s", teamEntity.Name, incidentSeverityEntity.Name, incidentSeverityEntity.Description, incidentEntity.IncidentName, incidentEntity.Title)
|
||||
att := slack.Attachment{
|
||||
Text: txt,
|
||||
Color: "#808080", // Grey color code
|
||||
MarkdownIn: []string{"txt"}, // Define which fields support markdown
|
||||
}
|
||||
_, _, errMessage = isp.client.PostMessage(callback.View.PrivateMetadata, slack.MsgOptionAttachments(att))
|
||||
if errMessage != nil {
|
||||
isp.logger.Error("post response failed for IncidentUpdateType", zap.Error(errMessage))
|
||||
return
|
||||
}
|
||||
|
||||
topic := fmt.Sprintf("%s-%s(%s) Incident-%d | %s", teamEntity.Name, incidentSeverityEntity.Name, incidentSeverityEntity.Description, incidentEntity.ID, incidentEntity.Title)
|
||||
isp.slackbotClient.SetChannelTopic(callback.View.PrivateMetadata, topic)
|
||||
}()
|
||||
var payload interface{}
|
||||
isp.client.Ack(*request, payload)
|
||||
}
|
||||
|
||||
0
service/team_tag_service.go
Normal file
0
service/team_tag_service.go
Normal file
Reference in New Issue
Block a user