varnitgoyal95/houston-be
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

INFRA-3000 | FIX: adding oncall into houston incidents (#391)

Browse Source
This commit is contained in:
Shashank Shekhar
2024-03-06 14:56:51 +05:30
committed by GitHub
parent 793c9183ec
commit 8a9c15cccc
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
service/incident/impl/incident_service_v2.go
View File

@@ -834,18 +834,16 @@ func addMembersToIncident(
severityEntity *severity.SeverityEntity,
incidentName string,
) error {
// 1. get list of team members, list of members by severity
var allUserFromDB []string
var allUserToBeAddedIntoIncident []string
var houstonUserList []string
var notHoustonUserList []string
if teamEntity.OncallHandle != "" {
allUserFromDB = append(allUserFromDB, teamEntity.OncallHandle)
allUserToBeAddedIntoIncident = append(allUserToBeAddedIntoIncident, teamEntity.OncallHandle)
}
if teamEntity.PseOncallHandle != "" {
allUserFromDB = append(allUserFromDB, teamEntity.PseOncallHandle)
allUserToBeAddedIntoIncident = append(allUserToBeAddedIntoIncident, teamEntity.PseOncallHandle)
}
teamUsers, err := i.teamUserService.GetTeamUsersWithMinimumSeverityIdLessThanOrEqualToGivenSeverity(teamEntity.ID, severityEntity.ID)
@@ -860,11 +858,9 @@ func addMembersToIncident(
}
}
for _, u := range houstonUserList {
allUserToBeAddedIntoIncident = append(allUserToBeAddedIntoIncident, u)
}
allUserToBeAddedIntoIncident = append(allUserToBeAddedIntoIncident, houstonUserList...)
uniqueUsersFromDB := util.RemoveDuplicate[string](allUserFromDB)
uniqueUsersToBeAdded := util.RemoveDuplicate[string](allUserToBeAddedIntoIncident)
var invalidUsersString string
var invalidUserCount uint
@@ -891,12 +887,12 @@ func addMembersToIncident(
_ = err
}
err = i.slackService.InviteUsersToConversation(channel.ID, allUserToBeAddedIntoIncident[:]...)
err = i.slackService.InviteUsersToConversation(channel.ID, uniqueUsersToBeAdded[:]...)
if err != nil {
logger.Error(
fmt.Sprintf(
"%s [%s] Error in adding members [%+v] to the channel %s",
logTag, incidentName, uniqueUsersFromDB, channel.Name,
logTag, incidentName, uniqueUsersToBeAdded, channel.Name,
),
zap.Error(err),
)