varnitgoyal95/houston-be
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TP-0000 | shifting unnecessary logic in async function (#94)

Browse Source
This commit is contained in:
Shubham Kirve
2023-06-14 12:02:07 +05:30
committed by GitHub Enterprise
parent 00390aba74
commit 4c80e19fbc
1 changed files with 16 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
internal/processor/action/incident_update_type_action.go
View File

@@ -110,30 +110,25 @@ func (itp *IncidentUpdateTypeAction) IncidentUpdateType(callback slack.Interacti
return
}
errMessage := util.PostIncidentTypeUpdateMessage(
user.ID, teamEntity.Name, severityEntity.Name, severityEntity.Description,
incidentEntity.IncidentName, incidentEntity.Title, callback.View.PrivateMetadata, itp.socketModeClient)
if errMessage != nil {
itp.logger.Error("post response failed for IncidentUpdateType", zap.Error(errMessage))
return
}
if errMessage != nil {
itp.logger.Error("post response failed for IncidentUpdateType", zap.Error(errMessage))
return
}
if len(teamEntity.ConfluenceLink) > 1 {
textForConfluence := fmt.Sprintf("*%s* -> <%s| Confluence Page>", teamEntity.Name, teamEntity.ConfluenceLink)
_, _, errMessage := itp.socketModeClient.PostMessage(callback.View.PrivateMetadata, slack.MsgOptionText(textForConfluence, false))
go func() {
errMessage := util.PostIncidentTypeUpdateMessage(
user.ID, teamEntity.Name, severityEntity.Name, severityEntity.Description,
incidentEntity.IncidentName, incidentEntity.Title, callback.View.PrivateMetadata, itp.socketModeClient)
if errMessage != nil {
itp.logger.Error("post response failed for IncidentUpdateType Confluence message", zap.Error(errMessage))
itp.logger.Error("post response failed for IncidentUpdateType", zap.Error(errMessage))
return
}
}
topic := fmt.Sprintf("%s-%s(%s) Incident-%d | %s", teamEntity.Name, severityEntity.Name, severityEntity.Description, incidentEntity.ID, incidentEntity.Title)
itp.slackbotClient.SetChannelTopic(callback.View.PrivateMetadata, topic)
if len(teamEntity.ConfluenceLink) > 1 {
textForConfluence := fmt.Sprintf("*%s* -> <%s| Confluence Page>", teamEntity.Name, teamEntity.ConfluenceLink)
_, _, errMessage := itp.socketModeClient.PostMessage(callback.View.PrivateMetadata, slack.MsgOptionText(textForConfluence, false))
if errMessage != nil {
itp.logger.Error("post response failed for IncidentUpdateType Confluence message", zap.Error(errMessage))
return
}
}
topic := fmt.Sprintf("%s-%s(%s) Incident-%d | %s", teamEntity.Name, severityEntity.Name, severityEntity.Description, incidentEntity.ID, incidentEntity.Title)
itp.slackbotClient.SetChannelTopic(callback.View.PrivateMetadata, topic)
}()
var payload interface{}
itp.socketModeClient.Ack(*request, payload)