Merge pull request #915 from navi-infra/INFRA-3219

INFRA-3219 | Harinder | Update resource action, review as a member of and ID for easier review and issue debugging

src/main/java/com/navi/infra/portal/v2/jit/utils/SlackBotUtil.java

@@ -25,10 +25,14 @@ public class SlackBotUtil {
         JitApproval jitApproval
     ) {
         return new ArrayList<>(Arrays.asList(
-            createField("Request ID", jitRequest.getId().toString()),
+            createField("ID",
+                String.join("-", jitRequest.getId().toString(),
+                                        jitApproval.getId().toString())),
             createField("User", userEmail),
             createField("Environment", jitRequest.getEnvironment().toString()),
             createField("Resource", jitRequest.getResourceType()),
+            createField("Action", jitRequest.getResourceAction()),
+            createField("Review as", jitApproval.getTeam().getName()),
             createField("Grant At/On",
                 jitRequest.getGrantAt().truncatedTo(ChronoUnit.MINUTES).toString()),
             createField("Status", jitApproval.getAction().toString())

src/test/java/com/navi/infra/portal/v2/jit/utils/SlackBotUtilTest.java

@@ -28,6 +28,7 @@ public class SlackBotUtilTest {
         jitApproval.setAction(JitRequestStatus.PENDING);
         jitApproval.setId(1L);
         jitRequest.setId(1L);
+        jitApproval.setTeam(new Team("Infra"));
 
         SlackBotAttachment result =
             slackBotUtil.getReviewerDm(userEmail, jitRequest, jitApproval, true, SlackColor.INFO);