075043a22e
* TP-00000 | added husky hooks and github * TP-00000 | lint changes and github actions * TP-00000 | lint changes and github actions * TP-00000 | prettier ignore * Testing lint * TP-00000 | prettier ignore * TP-00000 | prettier ignore * TP-00000 | prettier ignore * TP-00000 | prettier ignore * TP-00000 | prettier ignore * TP-00000 | prettier ignore * TP-00000 | prettier ignore * TP-00000 | prettier ignore * pretier fix * pretier fix * pretier fix * added github template * added github template
843 B
843 B
List of changes in this PR
PR reviews guidelines
- No magic numbers and magic strings
- improve naming of variables and functions
- improve typescript use
- no hardcoding of z-index and colours
- avoid date.now() we have server time available which is more consistent
- use optional chaining where ever possible.
- Trust but verify
- Never trust your dev intuitions, follow murphy law
- prefer functional programming
- more custom hooks
- reuse existing helper code
- Don’t use carret in package.json
- use of useMemo and useCallback
- Don't create components inside render function
- Don't create functions inside render function
- Don't use inline styles
- Don't use inline event handlers
- prefer to extract function outside jsx if more than two conditions are required
- Don't use any type
- Only use const and if required let