09d2dc4c72
* added code owner file * added code owner file * added code owner file * fix prettier and eslint * fix prettier and eslint * added github template
25 lines
843 B
Markdown
25 lines
843 B
Markdown
### List of changes in this PR
|
||
|
||
### PR reviews guidelines
|
||
|
||
- No magic numbers and magic strings
|
||
- improve naming of variables and functions
|
||
- improve typescript use
|
||
- no hardcoding of z-index and colours
|
||
- avoid date.now() we have server time available which is more consistent
|
||
- use optional chaining where ever possible.
|
||
- Trust but verify
|
||
- Never trust your dev intuitions, follow murphy law
|
||
- prefer functional programming
|
||
- more custom hooks
|
||
- reuse existing helper code
|
||
- Don’t use carret in package.json
|
||
- use of useMemo and useCallback
|
||
- Don't create components inside render function
|
||
- Don't create functions inside render function
|
||
- Don't use inline styles
|
||
- Don't use inline event handlers
|
||
- prefer to extract function outside jsx if more than two conditions are required
|
||
- Don't use any type
|
||
- Only use const and if required let
|