TP-62361 | PR comments resolved

This commit is contained in:
yashmantri
2024-07-15 15:41:07 +05:30
parent 6f38d06665
commit 2552371d0f
7 changed files with 22 additions and 8 deletions

View File

@@ -34,6 +34,11 @@ public class PhoneStateModule extends ReactContextBaseJavaModule {
@ReactMethod
public void getCurrentCallState(Promise promise) {
if (telephonyManager == null) {
promise.resolve("UNKNOWN");
return;
}
int state = telephonyManager.getCallState();
String currentCallState;

View File

@@ -49,7 +49,7 @@ const CallCannotInitiateBottomSheet = () => {
>
<View style={GenericStyles.alignCenter}>
<CallCannotInitiatedIcon />
<View style={{ paddingHorizontal: 30, paddingTop: 24 }}>
<View style={styles.container}>
<Text style={styles.headerTxt}>Call cannot be initiated!</Text>
<Text style={styles.descriptionTxt}>
There is already an ongoing call with <Text style={styles.name}>Abhinav</Text> on{' '}
@@ -90,6 +90,10 @@ const styles = StyleSheet.create({
fontSize: 12,
fontWeight: '500',
},
container: {
paddingHorizontal: 30,
paddingTop: 24,
},
});
export default CallCannotInitiateBottomSheet;

View File

@@ -59,7 +59,7 @@ const ConnectingToCustomerBottomSheet = (props: IConnectingToCustomerBottomSheet
>
<View style={GenericStyles.alignCenter}>
<ConnectingToCustomerIcon />
<View style={{ paddingHorizontal: 52, paddingTop: 24 }}>
<View style={styles.container}>
<Text style={styles.headerTxt}>Connecting you with the customer...</Text>
<Text style={styles.descriptionTxt}>
You will receive a call from NAVI. Post this a call will go to{' '}
@@ -99,6 +99,10 @@ const styles = StyleSheet.create({
fontSize: 12,
fontWeight: '500',
},
container: {
paddingHorizontal: 52,
paddingTop: 24,
},
});
export default ConnectingToCustomerBottomSheet;

View File

@@ -97,7 +97,7 @@ const CustomerNumbers = (props: ICustomerNumbers) => {
<Text style={styles.addNewNumberCta}>Add new number</Text>
</Pressable>
{mobileNumbers.map((number) => (
<PhoneNumberItem phoneNumber={number} caseId={caseId} />
<PhoneNumberItem key={number?.referenceId} phoneNumber={number} caseId={caseId} />
))}
</View>
</ScrollView>

View File

@@ -1,4 +1,4 @@
export const paymentLinkChannels = [
export const PAYMENT_LINK_CHANNELS = [
{ type: 'SMS', value: 'SMS' },
{ type: 'Whatsapp', value: 'WHATSAPP' },
{ type: 'Both', value: 'Both' },

View File

@@ -32,7 +32,7 @@ import ForeclosureBottomSheet from './ForeclosureBottomSheet';
import ForeclosureBreakupAccordion, { IForeclosureBreakup } from './ForeclosureBreakupAccordion';
import DropDownWrapper from '../../common/DropDownWrapper';
import { ITelephoneNumbers } from '@reducers/telephoneNumbersSlice';
import { paymentLinkChannels } from './Constants';
import { PAYMENT_LINK_CHANNELS } from './Constants';
import PressableChip from '@rn-ui-lib/components/PressableChip';
interface IForeclosure {
@@ -113,6 +113,7 @@ const Foreclosure: React.FC<IForeclosure> = ({ caseId, numbers, primaryPhoneNumb
const { createdAt, sourceText, referenceId } = phoneNumber;
return (
<DropdownItem
key={referenceId}
createdAt={createdAt}
id={referenceId}
label={getPhoneNumberString(phoneNumber)}
@@ -217,7 +218,7 @@ const Foreclosure: React.FC<IForeclosure> = ({ caseId, numbers, primaryPhoneNumb
/>
<Text style={[GenericStyles.mb8, GenericStyles.mt16]}>Send on</Text>
<View style={[GenericStyles.row, GenericStyles.flexWrap]}>
{paymentLinkChannels?.map((data, index) => (
{PAYMENT_LINK_CHANNELS?.map((data, index) => (
<Controller
key={data.value}
control={control}

View File

@@ -26,7 +26,7 @@ import { ToastMessages } from '../allCases/constants';
import DropDownWrapper from '../../common/DropDownWrapper';
import { ITelephoneNumbers } from '@reducers/telephoneNumbersSlice';
import PressableChip from '@rn-ui-lib/components/PressableChip';
import { paymentLinkChannels } from './Constants';
import { PAYMENT_LINK_CHANNELS } from './Constants';
interface IOnlinePayment {
caseId: string;
@@ -242,7 +242,7 @@ const OnlinePayment: React.FC<IOnlinePayment> = ({
</View>
<Text style={[GenericStyles.mb8, GenericStyles.mt16]}>Send on</Text>
<View style={[GenericStyles.row, GenericStyles.flexWrap]}>
{paymentLinkChannels?.map((data, index) => (
{PAYMENT_LINK_CHANNELS?.map((data, index) => (
<Controller
key={data.value}
control={control}