From e4e759a1bf81b8b5631e7abfcf8643bb8c2be9b3 Mon Sep 17 00:00:00 2001 From: Naman Khurmi Date: Mon, 5 May 2025 17:18:24 +0530 Subject: [PATCH] NTP-58594 | Naman Khurmi | App update analytic crash fix. (#16048) --- .../naviapp/common/viewmodel/InAppUpdateHelper.kt | 5 +---- .../com/navi/common/utils/CommonNaviAnalytics.kt | 12 ++---------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/android/app/src/main/java/com/naviapp/common/viewmodel/InAppUpdateHelper.kt b/android/app/src/main/java/com/naviapp/common/viewmodel/InAppUpdateHelper.kt index ef6db40bfe..0a6f339eb0 100644 --- a/android/app/src/main/java/com/naviapp/common/viewmodel/InAppUpdateHelper.kt +++ b/android/app/src/main/java/com/naviapp/common/viewmodel/InAppUpdateHelper.kt @@ -61,10 +61,7 @@ class InAppUpdateHelper( InstallStatus.DOWNLOADING -> { inAppUpdateBridge.setAppUpdateState(AppUpdateState.UPDATE_DOWNLOADING) naviAnalyticsInAppUpdate.onDownloadProgress( - bytesDownloaded = state.bytesDownloaded(), - totalBytesToDownload = state.totalBytesToDownload(), - downloadProgress = - (state.bytesDownloaded() * 100 / state.totalBytesToDownload()), + appUpdateInfo?.availableVersionCode() ) } InstallStatus.INSTALLING -> { diff --git a/android/navi-common/src/main/java/com/navi/common/utils/CommonNaviAnalytics.kt b/android/navi-common/src/main/java/com/navi/common/utils/CommonNaviAnalytics.kt index f16f47d81a..9c2d1fc64e 100644 --- a/android/navi-common/src/main/java/com/navi/common/utils/CommonNaviAnalytics.kt +++ b/android/navi-common/src/main/java/com/navi/common/utils/CommonNaviAnalytics.kt @@ -343,18 +343,10 @@ class CommonNaviAnalytics private constructor() { ) } - fun onDownloadProgress( - bytesDownloaded: Long, - totalBytesToDownload: Long, - downloadProgress: Long, - ) { + fun onDownloadProgress(versionCode: Int?) { NaviTrackEvent.trackEvent( "dev_in_app_update_download_progress", - mapOf( - "bytes_downloaded" to bytesDownloaded.toString(), - "total_bytes" to totalBytesToDownload.toString(), - "download_progress" to downloadProgress.toString(), - ), + mapOf("version_code" to (versionCode?.toString() ?: "")), ) }