From cc29ef70c699152d0dd470fc056d430ecc29a701 Mon Sep 17 00:00:00 2001 From: Aparna Vadlamani Date: Thu, 27 Feb 2025 20:00:43 +0530 Subject: [PATCH] NTP-38275 | Recent transaction colour fix + dashboard analytics (#15185) --- .../moneymanager/common/analytics/MMAnalytics.kt | 9 +++++++++ .../ui/DashboardContainerAnimatingEffect.kt | 15 +++++++++++++++ .../ui/DashboardRecentTransactionsSection.kt | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/common/analytics/MMAnalytics.kt b/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/common/analytics/MMAnalytics.kt index d4f00c0ff1..98c0b26f3a 100644 --- a/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/common/analytics/MMAnalytics.kt +++ b/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/common/analytics/MMAnalytics.kt @@ -411,6 +411,15 @@ interface DashboardEventTracker { @EventName("mm_dashboard_help_bottom_sheet_manage_consent_clicked") fun onDashboardHelpBottomSheetManageConsentClicked() + + @EventName("mm_animation_has_stopped_after_bottom_sheet_success") + fun animationHasStoppedAfterBottomSheetSuccess() + + @EventName("mm_marking_success_for_animation_status") + fun markingSuccessForAnimationStatus(status: String) + + @EventName("mm_dashboard_animation_started") + fun onDashboardAnimationStart(isUserOnboarded: Boolean) } @AutoGenerate diff --git a/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardContainerAnimatingEffect.kt b/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardContainerAnimatingEffect.kt index 36b497e10c..14fcda2ee8 100644 --- a/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardContainerAnimatingEffect.kt +++ b/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardContainerAnimatingEffect.kt @@ -27,6 +27,9 @@ import androidx.compose.ui.graphics.graphicsLayer import androidx.compose.ui.platform.LocalConfiguration import androidx.compose.ui.platform.LocalDensity import androidx.compose.ui.unit.dp +import com.navi.base.sharedpref.PreferenceManager +import com.navi.moneymanager.common.analytics.DashboardEventTrackerImpl +import com.navi.moneymanager.common.utils.Constants.MM_IS_USER_ONBOARDED import com.navi.moneymanager.postonboard.dashboard.model.BankSectionData import com.navi.moneymanager.postonboard.dashboard.model.CurrentItemOnDashboardState import com.navi.moneymanager.postonboard.dashboard.model.DashboardScreenUiEffect @@ -53,6 +56,11 @@ internal fun DashboardContainerAnimatingEffect( onEffect: (DashboardScreenUiEffect) -> Unit, headerSectionHeight: (height: Int) -> Unit, ) { + LaunchedEffect(Unit) { + DashboardEventTrackerImpl.onDashboardAnimationStart( + PreferenceManager.getBooleanPreference(MM_IS_USER_ONBOARDED) + ) + } var currentState by remember { mutableStateOf(CurrentItemOnDashboardState.EmptyState) @@ -146,10 +154,17 @@ internal fun DashboardContainerAnimatingEffect( LaunchedEffect(currentState) { if (shouldStopOnBoardingAnimation) { + DashboardEventTrackerImpl.animationHasStoppedAfterBottomSheetSuccess() if (currentState == CurrentItemOnDashboardState.EmptyState) { + DashboardEventTrackerImpl.markingSuccessForAnimationStatus( + currentState.javaClass.simpleName + ) onEvent(DashboardScreenUiEvent.MarkOnBoardingAnimationStatusSuccess) return@LaunchedEffect } else { + DashboardEventTrackerImpl.markingSuccessForAnimationStatus( + currentState.javaClass.simpleName + ) handleCurrentItemFadeOut(this) return@LaunchedEffect } diff --git a/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardRecentTransactionsSection.kt b/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardRecentTransactionsSection.kt index fb4879a10e..4346316b0c 100644 --- a/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardRecentTransactionsSection.kt +++ b/android/navi-money-manager/src/main/kotlin/com/navi/moneymanager/postonboard/dashboard/ui/DashboardRecentTransactionsSection.kt @@ -169,7 +169,7 @@ private fun SectionTitle(title: String) { MMText( text = title, modifier = Modifier.padding(all = 16.dp), - color = elexColors.base.text.staticWhite.standard, + color = elexColors.base.text.gray.standard, fontSize = 16.sp, fontWeight = FontWeightEnum.NAVI_BODY_DEMI_BOLD, lineHeight = 24.sp,