From 78540ffa2bed9dd139de3db599de360acb04f59e Mon Sep 17 00:00:00 2001 From: Shivam Goyal Date: Fri, 13 Jun 2025 14:30:05 +0530 Subject: [PATCH] NTP-73076 | Custom Plans - Experiment Removal (#16570) --- .../com/navi/bbps/common/NaviBbpsConstants.kt | 1 - .../utils/BbpsABTestingDefaultDataProvider.kt | 7 +----- .../PrepaidRechargeViewModel.kt | 23 ++++--------------- 3 files changed, 6 insertions(+), 25 deletions(-) diff --git a/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/NaviBbpsConstants.kt b/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/NaviBbpsConstants.kt index 1b796eddf7..d4343982da 100644 --- a/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/NaviBbpsConstants.kt +++ b/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/NaviBbpsConstants.kt @@ -116,7 +116,6 @@ const val PAYMENT_MODE_UPI = "UPI" // AB Testing experiments constant const val AB_EXPERIMENT_NAVIBBPS_FESTIVE_THEME = "festive-theme" const val AB_TESTING_PROJECT_ORIGIN_EXPERIMENT_NAME = "NaviBBPS-Project-Origin" -const val AB_TESTING_CUSTOM_PREPAID_PLANS_EXPERIMENT_NAME = "NaviBBPS-Custom-Prepaid-Plans" const val AB_TESTING_PROJECT_ORIGIN_EMAIL_SUB_EXPERIMENT_NAME = "NaviBBPS-Project-Origin-Email" // Navi Bbps Constants diff --git a/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/utils/BbpsABTestingDefaultDataProvider.kt b/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/utils/BbpsABTestingDefaultDataProvider.kt index d86551cc6f..2489597f02 100644 --- a/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/utils/BbpsABTestingDefaultDataProvider.kt +++ b/android/navi-bbps/src/main/kotlin/com/navi/bbps/common/utils/BbpsABTestingDefaultDataProvider.kt @@ -7,7 +7,6 @@ package com.navi.bbps.common.utils -import com.navi.bbps.common.AB_TESTING_CUSTOM_PREPAID_PLANS_EXPERIMENT_NAME import com.navi.bbps.common.AB_TESTING_PROJECT_ORIGIN_EXPERIMENT_NAME import com.navi.bbps.common.model.network.BbpsABTestingItemResponse import javax.inject.Inject @@ -18,11 +17,7 @@ class BbpsABTestingDefaultDataProvider @Inject constructor() { BbpsABTestingItemResponse( name = AB_TESTING_PROJECT_ORIGIN_EXPERIMENT_NAME, isEnabled = false, - ), - BbpsABTestingItemResponse( - name = AB_TESTING_CUSTOM_PREPAID_PLANS_EXPERIMENT_NAME, - isEnabled = false, - ), + ) ) } } diff --git a/android/navi-bbps/src/main/kotlin/com/navi/bbps/feature/prepaidrecharge/PrepaidRechargeViewModel.kt b/android/navi-bbps/src/main/kotlin/com/navi/bbps/feature/prepaidrecharge/PrepaidRechargeViewModel.kt index 439adc9394..040ed3331d 100644 --- a/android/navi-bbps/src/main/kotlin/com/navi/bbps/feature/prepaidrecharge/PrepaidRechargeViewModel.kt +++ b/android/navi-bbps/src/main/kotlin/com/navi/bbps/feature/prepaidrecharge/PrepaidRechargeViewModel.kt @@ -17,8 +17,6 @@ import com.navi.base.model.CtaData import com.navi.base.utils.NaviNetworkConnectivity import com.navi.base.utils.TrustedTimeAccessor import com.navi.base.utils.isNotNullAndNotEmpty -import com.navi.base.utils.orFalse -import com.navi.bbps.common.AB_TESTING_CUSTOM_PREPAID_PLANS_EXPERIMENT_NAME import com.navi.bbps.common.DATE_TIME_FORMAT_DATE_MONTH_NAME_YEAR import com.navi.bbps.common.DATE_TIME_FORMAT_DATE_MONTH_NAME_YEAR_INPUT import com.navi.bbps.common.MOBILE_NUMBER_SERIES_LENGTH @@ -29,7 +27,6 @@ import com.navi.bbps.common.model.config.NaviBbpsDefaultConfig import com.navi.bbps.common.model.view.PrepaidPlanItemLoadingState import com.navi.bbps.common.repository.BbpsCommonRepository import com.navi.bbps.common.session.NaviBbpsSessionHelper -import com.navi.bbps.common.usecase.GetABTestingExperimentUseCase import com.navi.bbps.common.usecase.NaviBbpsConfigUseCase import com.navi.bbps.common.usecase.RewardNudgeUseCase import com.navi.bbps.common.utils.NaviBbpsCommonUtils @@ -128,7 +125,6 @@ constructor( @NaviBbpsGsonBuilder private val gson: Gson, private val naviBbpsCommonRepository: BbpsCommonRepository, savedStateHandle: SavedStateHandle, - private val getABTestingExperimentUseCase: GetABTestingExperimentUseCase, ) : NaviBbpsBaseVM( naviBbpsVmData = @@ -464,20 +460,11 @@ constructor( operatorCode: OperatorCode, circleId: CircleId, ): List? { - return if ( - getABTestingExperimentUseCase - .execute(experimentName = AB_TESTING_CUSTOM_PREPAID_PLANS_EXPERIMENT_NAME) - ?.isEnabled - .orFalse() - ) { - getCustomPrepaidPlans( - phoneNumber = phoneNumberDetail.normalisedPhoneNumber, - operatorCode = operatorCode, - circleId = circleId, - ) ?: getGenericPrepaidPlans(operatorCode = operatorCode, circleId = circleId) - } else { - getGenericPrepaidPlans(operatorCode = operatorCode, circleId = circleId) - } + return getCustomPrepaidPlans( + phoneNumber = phoneNumberDetail.normalisedPhoneNumber, + operatorCode = operatorCode, + circleId = circleId, + ) ?: getGenericPrepaidPlans(operatorCode = operatorCode, circleId = circleId) } private suspend fun getGenericPrepaidPlans(