From 531d367ff94d7020096abaf6300e5f60687b4f5b Mon Sep 17 00:00:00 2001 From: Himanshu Tanwar Date: Sat, 24 Jun 2023 21:03:12 +0530 Subject: [PATCH] Dev videoplayer uat enhancement (#7034) * TP-33677 | quiz result lottie change * TP-00000 | video player uat enhancement --- .../navi/common/ui/fragment/RewardsAnnouncementFragment.kt | 5 +++-- .../src/main/res/layout/layout_rewards_announcement.xml | 4 ++-- .../res/layout/claims_terms_conditions_bottomsheet.xml | 7 +++---- .../main/res/layout/inline_exoplayer_controls_layout.xml | 1 + .../src/main/res/layout/video_player_widget_layout.xml | 6 +++--- navi-widgets/src/main/res/raw/quiz_getting_there.json | 2 +- 6 files changed, 13 insertions(+), 12 deletions(-) diff --git a/navi-common/src/main/java/com/navi/common/ui/fragment/RewardsAnnouncementFragment.kt b/navi-common/src/main/java/com/navi/common/ui/fragment/RewardsAnnouncementFragment.kt index e404045742..a0b2942134 100644 --- a/navi-common/src/main/java/com/navi/common/ui/fragment/RewardsAnnouncementFragment.kt +++ b/navi-common/src/main/java/com/navi/common/ui/fragment/RewardsAnnouncementFragment.kt @@ -36,6 +36,7 @@ import com.navi.common.utils.Constants.HTTP import com.navi.common.utils.Constants.REWARDS_ANNOUNCEMENT_SCREEN import com.navi.common.utils.toCtaData import com.navi.design.utils.dpToPxInInt +import com.navi.design.utils.ifMeasured import com.navi.design.utils.parseColorSafe import com.navi.design.utils.spannedText import com.navi.naviwidgets.extensions.setCornerRadius @@ -177,7 +178,7 @@ class RewardsAnnouncementFragment : it.parameters?.put(SCREEN_NAME, sourceScreenName.orEmpty()) NaviTrackEvent.trackEventOnClickStream(it.eventName.orEmpty(), it.parameters) } - binding.clContent.post { + binding.clContent.ifMeasured { binding.clContent.layoutParams.height = (binding.clContent.width / (rewardsAnnouncementData?.aspectRatio ?: ASPECT_RATIO)).roundToInt() @@ -188,7 +189,7 @@ class RewardsAnnouncementFragment : private fun applyMarginToIcon(extraMargin: Int) { binding.apply { - ivIcon.post { + ivIcon.ifMeasured { val topMargin = ivIcon.height / 2 + dpToPxInInt(extraMargin) val layoutParams = tvTitle.layoutParams as ConstraintLayout.LayoutParams layoutParams.topMargin = topMargin diff --git a/navi-common/src/main/res/layout/layout_rewards_announcement.xml b/navi-common/src/main/res/layout/layout_rewards_announcement.xml index 0a184cec89..4c2a680478 100644 --- a/navi-common/src/main/res/layout/layout_rewards_announcement.xml +++ b/navi-common/src/main/res/layout/layout_rewards_announcement.xml @@ -45,8 +45,8 @@ android:id="@+id/clContent" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginStart="@dimen/dp_30" - android:layout_marginEnd="@dimen/dp_30" + android:layout_marginStart="@dimen/dp_16" + android:layout_marginEnd="@dimen/dp_16" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/navi-insurance/src/main/res/layout/claims_terms_conditions_bottomsheet.xml b/navi-insurance/src/main/res/layout/claims_terms_conditions_bottomsheet.xml index 06cfc46f6f..4df7010bd5 100644 --- a/navi-insurance/src/main/res/layout/claims_terms_conditions_bottomsheet.xml +++ b/navi-insurance/src/main/res/layout/claims_terms_conditions_bottomsheet.xml @@ -46,14 +46,13 @@