diff --git a/android/app/src/main/java/com/naviapp/home/dashboard/ui/compose/investmentTab/widgets/BannerWithActionCardWidgetComposable.kt b/android/app/src/main/java/com/naviapp/home/dashboard/ui/compose/investmentTab/widgets/BannerWithActionCardWidgetComposable.kt index 2fdf3e98e0..e7f6c7faee 100644 --- a/android/app/src/main/java/com/naviapp/home/dashboard/ui/compose/investmentTab/widgets/BannerWithActionCardWidgetComposable.kt +++ b/android/app/src/main/java/com/naviapp/home/dashboard/ui/compose/investmentTab/widgets/BannerWithActionCardWidgetComposable.kt @@ -48,12 +48,12 @@ fun BannerWithActionCardComposable( (LocalConfiguration.current.screenWidthDp) * (content.lottie?.aspectRatio ?: R.integer.value_1.toFloat()) - content.image?.let { + content.image?.url?.let { NaviImage( modifier = Modifier.height(illustrationHeight.dp) .width(LocalConfiguration.current.screenWidthDp.dp), - imageFieldData = it + imageFieldData = content.image ) } ?: content.lottie?.let { diff --git a/android/app/src/main/java/com/naviapp/home/dashboard/viewmodels/InvestmentsVm.kt b/android/app/src/main/java/com/naviapp/home/dashboard/viewmodels/InvestmentsVm.kt index ba54e946d5..b27e8523ca 100644 --- a/android/app/src/main/java/com/naviapp/home/dashboard/viewmodels/InvestmentsVm.kt +++ b/android/app/src/main/java/com/naviapp/home/dashboard/viewmodels/InvestmentsVm.kt @@ -31,7 +31,6 @@ import com.navi.common.utils.isValidResponse import com.navi.common.utils.toCtaData import com.navi.common.viewmodel.BaseVM import com.navi.naviwidgets.models.response.TextFieldData -import com.naviapp.R import com.naviapp.home.dashboard.models.investmentTabWidgetData.CutOffSlotData import com.naviapp.home.dashboard.models.investmentTabWidgetData.CutOffTimerWidget import com.naviapp.home.dashboard.models.response.GenericComposableWidgetInfo @@ -183,13 +182,7 @@ constructor( if (isLoading) { _investmentsTabScreenData.update { InvestmentsTabScreenState.Loading } } else { - val error = - ErrorUnifiedResponse( - errorResponse = - GenericErrorResponse( - message = R.string.error.toString(), - ) - ) + val error = ErrorUnifiedResponse(errorResponse = GenericErrorResponse()) _investmentsTabScreenData.update { InvestmentsTabScreenState.Error(error.errorResponse) } diff --git a/android/navi-common/src/main/java/com/navi/common/checkmate/model/MetricInfo.kt b/android/navi-common/src/main/java/com/navi/common/checkmate/model/MetricInfo.kt index a5e91d36dd..6b98596e8f 100644 --- a/android/navi-common/src/main/java/com/navi/common/checkmate/model/MetricInfo.kt +++ b/android/navi-common/src/main/java/com/navi/common/checkmate/model/MetricInfo.kt @@ -125,6 +125,18 @@ sealed class MetricInfo( isNae = isNae ) + data class UnknownMetric( + override val screen: String, + override val isNae: (RepoResult) -> Boolean = { + it.error != null || !it.errors.isNullOrEmpty() + }, + ) : + MetricInfo>( + screen = screen, + vertical = ModuleNameV2.COMMON.name, + isNae = isNae + ) + companion object { fun getVerticalMetric( response: Response> @@ -217,7 +229,7 @@ sealed class MetricInfo( ModuleNameV2.REWARDS.name -> RewardMetric(screenName, isNae) ModuleNameV2.App.name -> AppMetric(screenName, isNae) ModuleNameV2.GOLD.name -> GoldMetric(screenName, isNae) - else -> AppMetric(screenName, isNae) + else -> UnknownMetric(screenName, isNae) } }