NTP-14671 | Investments Regression 5.26.0 (#13742)
Co-authored-by: Varun Jain <varun.jain@navi.com>
This commit is contained in:
@@ -48,12 +48,12 @@ fun BannerWithActionCardComposable(
|
||||
(LocalConfiguration.current.screenWidthDp) *
|
||||
(content.lottie?.aspectRatio ?: R.integer.value_1.toFloat())
|
||||
|
||||
content.image?.let {
|
||||
content.image?.url?.let {
|
||||
NaviImage(
|
||||
modifier =
|
||||
Modifier.height(illustrationHeight.dp)
|
||||
.width(LocalConfiguration.current.screenWidthDp.dp),
|
||||
imageFieldData = it
|
||||
imageFieldData = content.image
|
||||
)
|
||||
}
|
||||
?: content.lottie?.let {
|
||||
|
||||
@@ -31,7 +31,6 @@ import com.navi.common.utils.isValidResponse
|
||||
import com.navi.common.utils.toCtaData
|
||||
import com.navi.common.viewmodel.BaseVM
|
||||
import com.navi.naviwidgets.models.response.TextFieldData
|
||||
import com.naviapp.R
|
||||
import com.naviapp.home.dashboard.models.investmentTabWidgetData.CutOffSlotData
|
||||
import com.naviapp.home.dashboard.models.investmentTabWidgetData.CutOffTimerWidget
|
||||
import com.naviapp.home.dashboard.models.response.GenericComposableWidgetInfo
|
||||
@@ -183,13 +182,7 @@ constructor(
|
||||
if (isLoading) {
|
||||
_investmentsTabScreenData.update { InvestmentsTabScreenState.Loading }
|
||||
} else {
|
||||
val error =
|
||||
ErrorUnifiedResponse(
|
||||
errorResponse =
|
||||
GenericErrorResponse(
|
||||
message = R.string.error.toString(),
|
||||
)
|
||||
)
|
||||
val error = ErrorUnifiedResponse(errorResponse = GenericErrorResponse())
|
||||
_investmentsTabScreenData.update {
|
||||
InvestmentsTabScreenState.Error(error.errorResponse)
|
||||
}
|
||||
|
||||
@@ -125,6 +125,18 @@ sealed class MetricInfo<T>(
|
||||
isNae = isNae
|
||||
)
|
||||
|
||||
data class UnknownMetric<T>(
|
||||
override val screen: String,
|
||||
override val isNae: (RepoResult<T>) -> Boolean = {
|
||||
it.error != null || !it.errors.isNullOrEmpty()
|
||||
},
|
||||
) :
|
||||
MetricInfo<RepoResult<T>>(
|
||||
screen = screen,
|
||||
vertical = ModuleNameV2.COMMON.name,
|
||||
isNae = isNae
|
||||
)
|
||||
|
||||
companion object {
|
||||
fun <T> getVerticalMetric(
|
||||
response: Response<GenericResponse<T>>
|
||||
@@ -217,7 +229,7 @@ sealed class MetricInfo<T>(
|
||||
ModuleNameV2.REWARDS.name -> RewardMetric(screenName, isNae)
|
||||
ModuleNameV2.App.name -> AppMetric(screenName, isNae)
|
||||
ModuleNameV2.GOLD.name -> GoldMetric(screenName, isNae)
|
||||
else -> AppMetric(screenName, isNae)
|
||||
else -> UnknownMetric(screenName, isNae)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user