From 34612f76970716ac6dd7bb720e2359aa2a60a296 Mon Sep 17 00:00:00 2001 From: Shaurya Rehan Date: Wed, 15 Jan 2025 20:03:36 +0530 Subject: [PATCH] NTP-28462 | upi request id empty check (#14538) --- .../com/navi/pay/common/usecase/DisableUpiLiteUseCase.kt | 5 +++++ .../usecase/SubsequentLiteMandateExecutionUseCase.kt | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/DisableUpiLiteUseCase.kt b/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/DisableUpiLiteUseCase.kt index fd60a43025..c8892b83a4 100644 --- a/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/DisableUpiLiteUseCase.kt +++ b/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/DisableUpiLiteUseCase.kt @@ -146,6 +146,11 @@ constructor( lrn: String, ) { val upiRequestId = upiRequestIdUseCase.execute() + if (upiRequestId.isBlank()) { + naviPayAnalytics.onDevGenericEvent(event = "DisableUpiLiteUseCase_UpiRequestIdBlank") + disableUpiLiteAction.emit(DisableUpiLiteAction(status = DisableUpiLiteStatus.FAILED)) + return + } val txnTimeStamp = getDateTimeStringWithYearOffset() val formattedAmount = balance.getFormattedAmountWithDecimal() diff --git a/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/SubsequentLiteMandateExecutionUseCase.kt b/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/SubsequentLiteMandateExecutionUseCase.kt index 8490f0acc2..9f3246e3b2 100644 --- a/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/SubsequentLiteMandateExecutionUseCase.kt +++ b/android/navi-pay/src/main/kotlin/com/navi/pay/common/usecase/SubsequentLiteMandateExecutionUseCase.kt @@ -151,6 +151,14 @@ constructor( ) val bankAccountUniqueId = upiLiteMandateInfo.bankAccountUniqueId.orEmpty() + val upiRequestId = upiRequestIdUseCase.execute() + + if (upiRequestId.isBlank()) { + naviPayAnalytics.onDevGenericEvent( + event = "SubsequentLiteMandateExecution_UpiRequestIdBlank" + ) + return + } val executeMandateRequest = ExecuteMandateRequest(