From 2dd2bac22948d334216005f1c0dabc2316166e6a Mon Sep 17 00:00:00 2001 From: nikhil kumar Date: Thu, 8 Aug 2024 17:26:35 +0530 Subject: [PATCH] TP-75974 | Nux cross icon check on content description instead of button text (#12031) --- .../benchmark/baselineprofile/NaviBaselineProfile.kt | 2 +- .../com/naviapp/benchmark/utils/HomePageActions.kt | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/android/benchmark/src/main/java/com/naviapp/benchmark/baselineprofile/NaviBaselineProfile.kt b/android/benchmark/src/main/java/com/naviapp/benchmark/baselineprofile/NaviBaselineProfile.kt index 2fb0df9de5..2fc177e2fb 100644 --- a/android/benchmark/src/main/java/com/naviapp/benchmark/baselineprofile/NaviBaselineProfile.kt +++ b/android/benchmark/src/main/java/com/naviapp/benchmark/baselineprofile/NaviBaselineProfile.kt @@ -28,7 +28,7 @@ class NaviBaselineProfile { @RequiresApi(Build.VERSION_CODES.P) @Test fun generate() = - baselineProfileRule.collect(PACKAGE_NAME) { + baselineProfileRule.collect(PACKAGE_NAME, maxIterations = 10) { startActivityAndAllowPermissions() performLogin() waitForHomePage() diff --git a/android/benchmark/src/main/java/com/naviapp/benchmark/utils/HomePageActions.kt b/android/benchmark/src/main/java/com/naviapp/benchmark/utils/HomePageActions.kt index cf59c88a85..08be2ddd15 100644 --- a/android/benchmark/src/main/java/com/naviapp/benchmark/utils/HomePageActions.kt +++ b/android/benchmark/src/main/java/com/naviapp/benchmark/utils/HomePageActions.kt @@ -16,22 +16,19 @@ import java.util.concurrent.TimeUnit fun MacrobenchmarkScope.waitForHomePage() { val okButton = By.text("OK") - val dialog = device.wait(Until.findObject(okButton), TimeUnit.SECONDS.toMillis(5)) + val dialog = device.wait(Until.findObject(okButton), TimeUnit.SECONDS.toMillis(10)) dialog?.let { it.click() - device.wait(Until.gone(okButton), TimeUnit.SECONDS.toMillis(5)) + device.wait(Until.gone(okButton), TimeUnit.SECONDS.toMillis(10)) } // Sometime location popup coming two times so adding one more check val dialog2 = device.wait(Until.findObject(okButton), TimeUnit.SECONDS.toMillis(5)) dialog2?.let { it.click() - device.wait(Until.gone(okButton), TimeUnit.SECONDS.toMillis(5)) + device.wait(Until.gone(okButton), TimeUnit.SECONDS.toMillis(10)) } val nux = - device.wait( - Until.findObject(By.text("Make your first payment")), - TimeUnit.SECONDS.toMillis(10) - ) + device.wait(Until.findObject(By.desc("nux_left_cross_icon")), TimeUnit.SECONDS.toMillis(10)) nux?.let { device.pressBack() } device.wait(Until.hasObject(By.clazz(HOME_PAGE_CLASS_NAME)), TimeUnit.SECONDS.toMillis(10)) }