From 21d34e7e27bfbbbe3ce344bec8df824949c11bed Mon Sep 17 00:00:00 2001
From: Shaurya Rehan <shaurya.rehan@navi.com>
Date: Wed, 19 Mar 2025 20:09:38 +0530
Subject: [PATCH] NTP-39209 | bug fix auto read otp (#15452)

---
 .../main/java/com/naviapp/registration/OtpFragment.kt  |  8 ++++----
 .../binding/viewmodel/NaviPayOnboardingViewModel.kt    | 10 ++++++----
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/android/app/src/main/java/com/naviapp/registration/OtpFragment.kt b/android/app/src/main/java/com/naviapp/registration/OtpFragment.kt
index 56f1274606..a74835371a 100644
--- a/android/app/src/main/java/com/naviapp/registration/OtpFragment.kt
+++ b/android/app/src/main/java/com/naviapp/registration/OtpFragment.kt
@@ -160,6 +160,10 @@ class OtpFragment : BaseFragment(), View.OnClickListener {
     private fun initObservers() {
         registrationVM.loginOtpVerifyResponse.observeNonNull(this) { otpVerifyResponse ->
             if (otpVerifyResponse.idToken.isNotNullAndNotEmpty()) {
+                PreferenceManager.setBooleanSecurely(
+                    key = AUTO_READ_OTP_CONSENT_KEY,
+                    value = otpAutofill,
+                )
                 loginListener.login(
                     loginRequest =
                         UserLoginRequest(
@@ -362,10 +366,6 @@ class OtpFragment : BaseFragment(), View.OnClickListener {
     }
 
     private fun verifyOtp(isAutoFetchOtp: Boolean = false) {
-        PreferenceManager.setBooleanSecurely(
-            key = AUTO_READ_OTP_CONSENT_KEY,
-            value = isAutoFetchOtp,
-        )
         otpAutofill = isAutoFetchOtp
         if (
             System.currentTimeMillis() - apiCallLastTime <=
diff --git a/android/navi-pay/src/main/kotlin/com/navi/pay/onboarding/binding/viewmodel/NaviPayOnboardingViewModel.kt b/android/navi-pay/src/main/kotlin/com/navi/pay/onboarding/binding/viewmodel/NaviPayOnboardingViewModel.kt
index 67ba3392ce..b223b63d9f 100644
--- a/android/navi-pay/src/main/kotlin/com/navi/pay/onboarding/binding/viewmodel/NaviPayOnboardingViewModel.kt
+++ b/android/navi-pay/src/main/kotlin/com/navi/pay/onboarding/binding/viewmodel/NaviPayOnboardingViewModel.kt
@@ -1770,10 +1770,6 @@ constructor(
             updateAutoReadOtpVerificationState(AutoReadOtpVerificationState.VERIFYING)
             otpTimerJob?.cancel()
             updateOtpTimeOut(otpTimeOut = 30)
-            sharedPreferenceRepository.setBooleanValueSecurely(
-                key = AUTO_READ_OTP_CONSENT_KEY,
-                value = true,
-            )
 
             val verifyOtpResponse =
                 naviCommonRepository.verifyOtp(
@@ -1803,6 +1799,12 @@ constructor(
                 )
                 return@launch
             }
+
+            sharedPreferenceRepository.setBooleanValueSecurely(
+                key = AUTO_READ_OTP_CONSENT_KEY,
+                value = true,
+            )
+
             startSimBinding()
         }
     }