64 lines
1.8 KiB
Markdown
64 lines
1.8 KiB
Markdown
|
<!--
|
|||
|
|
|
|||
|
|
Please use the content below as a template for your pull request.
|
|||
|
|
Feel free to remove sections which do not make sense.
|
|||
|
|
|
|||
|
|
-->
|
|||
|
|
|
|||
|
|
## Scope
|
|||
|
|
|
|||
|
|
<!-- Brief description of WHAT you’re doing and WHY. -->
|
|||
|
|
|
|||
|
|
[closes TICKET-###](https://link-to-your-ticket)
|
|||
|
|
|
|||
|
|
## Implementation
|
|||
|
|
|
|||
|
|
With @pair
|
|||
|
|
|
|||
|
|
<!--
|
|||
|
|
|
|||
|
|
Some description of HOW you achieved it. Perhaps give a high level description of the program flow. Did you need to refactor something? What tradeoffs did you take? Are there things in here which you’d particularly like people to pay close attention to?
|
|||
|
|
|
|||
|
|
-->
|
|||
|
|
|
|||
|
|
## Screenshots
|
|||
|
|
|
|||
|
|
| | before | after |
|
|||
|
|
| ------- | ------ | ----- |
|
|||
|
|
| desktop | | |
|
|||
|
|
| mobile | | |
|
|||
|
|
|
|||
|
|
## How to Test
|
|||
|
|
|
|||
|
|
<!--
|
|||
|
|
|
|||
|
|
A straightforward scenario of how to test your changes could help colleagues that are not familiar with the part of the code that you are changing but want to see it in action. This section can include a description or step-by-step instructions of how to get to the state of v2 that your change affects.
|
|||
|
|
|
|||
|
|
A "How To Test" section can look something like this:
|
|||
|
|
|
|||
|
|
- Sign in with a user with tracks
|
|||
|
|
- Activate `show_awesome_cat_gifs` feature (add `?feature.show_awesome_cat_gifs=1` to your URL)
|
|||
|
|
- You should see a GIF with cats dancing
|
|||
|
|
|
|||
|
|
-->
|
|||
|
|
|
|||
|
|
## Emoji Guide
|
|||
|
|
|
|||
|
|
**For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.**
|
|||
|
|
|
|||
|
|
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
|
|||
|
|
|
|||
|
|
> 🟢 Nice refactor!
|
|||
|
|
|
|||
|
|
> 🟡 Why was the default value removed?
|
|||
|
|
|
|||
|
|
E.g: Blocking feedback must be addressed before merging.
|
|||
|
|
|
|||
|
|
> 🔴 This change will break something important
|
|||
|
|
|
|||
|
|
| | | |
|
|||
|
|
| --- | --- | --- |
|
|||
|
|
| Blocking | 🔴 ❌ 🚨 | RED |
|
|||
|
|
| Non-blocking | 🟡 💡 🤔 💭 | Yellow, thinking, etc |
|
|||
|
|
| Praise | 🟢 💚 😍 👍 🙌 | Green, hearts, positive emojis, etc |
|