From bb1cc2d292d0ae0eaff10721eef7337d9032d22b Mon Sep 17 00:00:00 2001
From: aishwarya-raimule <aishwarya.raimule@navi.com>
Date: Thu, 2 Feb 2023 17:47:11 +0530
Subject: [PATCH] removed success counter as it was redundant

---
 instrumentation/metrics.go  | 8 --------
 producer/kafka_writer.go    | 7 -------
 producer/producer_client.go | 1 -
 3 files changed, 16 deletions(-)

diff --git a/instrumentation/metrics.go b/instrumentation/metrics.go
index 6cdeb52..6688316 100644
--- a/instrumentation/metrics.go
+++ b/instrumentation/metrics.go
@@ -13,14 +13,6 @@ var KafkaPushCounter = promauto.NewCounterVec(
 	[]string{"topic", "source"},
 )
 
-var ProducerSuccessCounter = promauto.NewCounterVec(
-	prometheus.CounterOpts{
-		Name: "janus_producer_send_success",
-		Help: "Number of Success requests.",
-	},
-	[]string{"topic"},
-)
-
 var ProducerFailCounter = promauto.NewCounterVec(
 	prometheus.CounterOpts{
 		Name: "janus_producer_send_fail",
diff --git a/producer/kafka_writer.go b/producer/kafka_writer.go
index 4f6ffa9..9bb3b81 100644
--- a/producer/kafka_writer.go
+++ b/producer/kafka_writer.go
@@ -16,13 +16,6 @@ func WriteMessageToKafkaAsync(message *sarama.ProducerMessage, source string) {
 	logger.Debug("SUCCESSFULLY WRITTEN TO KAFKA FOR SOURCE " + source)
 }
 
-func processProducerSuccesses() {
-	for {
-		msg := <-asyncProducer.Successes()
-		metrics.ProducerSuccessCounter.WithLabelValues(msg.Topic).Inc()
-	}
-}
-
 func processProducerErrors() {
 	for {
 		err := <-asyncProducer.Errors()
diff --git a/producer/producer_client.go b/producer/producer_client.go
index c4fa093..8c4b9ad 100644
--- a/producer/producer_client.go
+++ b/producer/producer_client.go
@@ -92,7 +92,6 @@ func GetAsyncProducer(kafkaConfiguration config.KafkaConfigurations, env string)
 		panic(err)
 	}
 
-	go processProducerSuccesses()
 	go processProducerErrors()
 	return producer
 }