From e4578c6fb56fd1fcbf00f87d2dcb9e26054377b8 Mon Sep 17 00:00:00 2001
From: Ankit Bhardwaj <ankit.bhardwaj@navi.com>
Date: Tue, 7 Nov 2023 19:25:39 +0530
Subject: [PATCH] INFRA-2265 | Ankit Bhardwaj | add vertical argument in test
 struct getdeploymentportal url

---
 main_test.go                          | 45 ++++++++++++++-------------
 testdata/sample_infra_manifest_3.json | 19 -----------
 testdata/sample_infra_manifest_4.json | 19 -----------
 3 files changed, 24 insertions(+), 59 deletions(-)
 delete mode 100644 testdata/sample_infra_manifest_3.json
 delete mode 100644 testdata/sample_infra_manifest_4.json

diff --git a/main_test.go b/main_test.go
index 93647e6..dbee5bf 100644
--- a/main_test.go
+++ b/main_test.go
@@ -180,38 +180,39 @@ func Test_getDeploymentPortalUrl(t *testing.T) {
 	testCases := []struct {
 		name         string
 		manifestFile string
+		vertical     string
 		expectedURL  string
 		setEnv       bool
 	}{
 		{
-			name:         "Correct Lending Vertical URL should be generated",
-			manifestFile: "sample_infra_manifest",
-			expectedURL:  "https://deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
-			setEnv:       false,
+			name:        "Correct Lending Vertical URL should be generated",
+			expectedURL: "https://deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
+			vertical:    "lending",
+			setEnv:      false,
 		},
 		{
-			name:         "Correct Insurance Vertical URL should be generated",
-			manifestFile: "sample_infra_manifest_2",
-			expectedURL:  "https://gi-deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
-			setEnv:       false,
+			name:        "Correct Insurance Vertical URL should be generated",
+			expectedURL: "https://gi-deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
+			vertical:    "insurance",
+			setEnv:      false,
 		},
 		{
-			name:         "Correct for localhost URL should be generated",
-			manifestFile: "sample_infra_manifest",
-			expectedURL:  "http://localhost:8080/api/manifest/status/env/dev/name/foo",
-			setEnv:       true,
+			name:        "Correct for localhost URL should be generated",
+			expectedURL: "http://localhost:8080/api/manifest/status/env/dev/name/foo",
+			vertical:    "test",
+			setEnv:      true,
 		},
 		{
-			name:         "Correct Navi-pay Vertical URL should be generated",
-			manifestFile: "sample_infra_manifest_3",
-			expectedURL:  "https://navi-pay-deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
-			setEnv:       false,
+			name:        "Correct Navi-pay Vertical URL should be generated",
+			expectedURL: "https://navi-pay-deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
+			vertical:    "navi-pay",
+			setEnv:      false,
 		},
 		{
-			name:         "Correct Sa Vertical URL should be generated",
-			manifestFile: "sample_infra_manifest_4",
-			expectedURL:  "https://sa-deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
-			setEnv:       false,
+			name:        "Correct Sa Vertical URL should be generated",
+			expectedURL: "https://sa-deployment-portal-backend.cmd.navi-tech.in/api/manifest/status/env/dev/name/foo",
+			vertical:    "sa",
+			setEnv:      false,
 		},
 	}
 	for _, testCase := range testCases {
@@ -224,8 +225,10 @@ func Test_getDeploymentPortalUrl(t *testing.T) {
 			}()
 			testActions, err := setActions(true, false, false)
 			assert.NoError(t, err)
-			manifest, err := parseManifest(filepath.Join(testDataDir, testCase.manifestFile+".json"), testActions)
+			manifestFile := "sample_infra_manifest.json"
+			manifest, err := parseManifest(filepath.Join(testDataDir, manifestFile), testActions)
 			assert.NoError(t, err)
+			manifest.InfraVertical = testCase.vertical
 			actualURL := getDeploymentPortalUrl(manifest)
 			assert.Equal(t, testCase.expectedURL, actualURL)
 		})
diff --git a/testdata/sample_infra_manifest_3.json b/testdata/sample_infra_manifest_3.json
deleted file mode 100644
index 3ca50f6..0000000
--- a/testdata/sample_infra_manifest_3.json
+++ /dev/null
@@ -1,19 +0,0 @@
-{
-  "environment": "dev",
-  "cluster": "aps1.np.navi-gi.in",
-  "metadata": {
-    "repo": "navi-medici/test",
-    "language": "Java"
-  },
-  "deployment": {
-    "namespace": "dev-3p"
-  },
-  "extraResources": {
-    "environment": "dev"
-  },
-  "team": {
-    "name": "Infra"
-  },
-  "name": "foo",
-  "infraVertical": "navi-pay"
-}
diff --git a/testdata/sample_infra_manifest_4.json b/testdata/sample_infra_manifest_4.json
deleted file mode 100644
index e079623..0000000
--- a/testdata/sample_infra_manifest_4.json
+++ /dev/null
@@ -1,19 +0,0 @@
-{
-  "environment": "dev",
-  "cluster": "aps1.np.navi-gi.in",
-  "metadata": {
-    "repo": "navi-medici/test",
-    "language": "Java"
-  },
-  "deployment": {
-    "namespace": "dev-3p"
-  },
-  "extraResources": {
-    "environment": "dev"
-  },
-  "team": {
-    "name": "Infra"
-  },
-  "name": "foo",
-  "infraVertical": "sa"
-}
\ No newline at end of file