From f40eb669a3410ec363dd75700b406aa2c2bf5518 Mon Sep 17 00:00:00 2001 From: Vijay Joshi Date: Thu, 14 Mar 2024 14:44:57 +0530 Subject: [PATCH] INFRA-3026 : Skip already_in_channel error for alerting during auto escalation (#398) --- common/util/constant.go | 11 ++++++----- internal/cron/cron.go | 4 +++- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/common/util/constant.go b/common/util/constant.go index be580bf..00531ec 100644 --- a/common/util/constant.go +++ b/common/util/constant.go @@ -43,11 +43,12 @@ const ( ) const ( - UserChangeEvent = "user_change" - DeactivatedUserName = "Deactivated User" - AlreadyArchivedError = "already_archived" - NotInChannelError = "not_in_channel" - NotFoundError = "not found" + UserChangeEvent = "user_change" + DeactivatedUserName = "Deactivated User" + AlreadyArchivedError = "already_archived" + NotInChannelError = "not_in_channel" + NotFoundError = "not found" + AlreadyInChannelError = "already_in_channel" ) const ( diff --git a/internal/cron/cron.go b/internal/cron/cron.go index 8a63f5b..3151025 100644 --- a/internal/cron/cron.go +++ b/internal/cron/cron.go @@ -197,7 +197,9 @@ func updatingSevForEachInc(incidents []incident.IncidentEntity, i int, incidentS _, err := socketModeClient.Client.InviteUsersToConversation(incidents[i].SlackChannel, o) if err != nil { logger.Error("Slack Client InviteUsersToConversation error in cron job") - metrics.PublishCronJobFailureMetrics(AUTO_ESCALATE, err.Error()) + if err.Error() != util.AlreadyInChannelError { + metrics.PublishCronJobFailureMetrics(AUTO_ESCALATE, err.Error()) + } } }