varnitgoyal95/houston-be
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

INFRA-3565 : Remove retrospective and service owner in incident roles (#434)

Browse Source 
* INFRA-3565 : Remove retrospective and service owner in incident roles

* INFRA-3565 : Build failure fix
This commit is contained in:
Vijay Joshi
2024-07-11 14:53:39 +05:30
committed by GitHub
parent 9448e8ec83
commit 293220ded8
4 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/processor/action/view/incident_assign.go
View File

@@ -22,20 +22,6 @@ func GenerateModalForIncidentAssign(channel slack.Channel) slack.ModalViewReques
}, },
Value: string(incident.Responder), Value: string(incident.Responder),
}, },
{
Text: &slack.TextBlockObject{
Type: slack.PlainTextType,
Text: string(incident.ServiceOwner),
},
Value: string(incident.ServiceOwner),
},
{
Text: &slack.TextBlockObject{
Type: slack.PlainTextType,
Text: string(incident.Retrospective),
},
Value: string(incident.Retrospective),
},
} }
rolePlaceholder := slack.NewTextBlockObject(slack.PlainTextType, "Select a role", false, false) rolePlaceholder := slack.NewTextBlockObject(slack.PlainTextType, "Select a role", false, false)

4
model/incident/entity.go
View File

@@ -22,9 +22,7 @@ const (
) )
const ( const (
Retrospective IncidentRole = "Retrospective" Responder IncidentRole = "Responder"
Responder = "Responder"
ServiceOwner = "Service Owner"
) )
type IncidentRole string type IncidentRole string

4
service/incident/impl/incident_service_test.go
View File

@@ -406,7 +406,7 @@ func (suite *IncidentServiceSuite) Test_GetAllIncidents_SuccessCase() {
func (suite *IncidentServiceSuite) Test_GetIncidentRolesByIncidentIdsAndRole_DBError() { func (suite *IncidentServiceSuite) Test_GetIncidentRolesByIncidentIdsAndRole_DBError() {
incidentIds := []uint{1, 2} incidentIds := []uint{1, 2}
suite.incidentRepository.GetIncidentRolesByIncidentIdsAndRoleMock.Return(nil, errors.New("DB error")) suite.incidentRepository.GetIncidentRolesByIncidentIdsAndRoleMock.Return(nil, errors.New("DB error"))
_, err := suite.incidentService.GetIncidentRolesByIncidentIdsAndRole(incidentIds, incident.Responder) _, err := suite.incidentService.GetIncidentRolesByIncidentIdsAndRole(incidentIds, string(incident.Responder))
suite.Error(err) suite.Error(err)
} }
@@ -414,7 +414,7 @@ func (suite *IncidentServiceSuite) Test_GetIncidentRolesByIncidentIdsAndRole_Suc
mockIncidentRoles := []incident.IncidentRoleEntity{{IncidentId: 1, Role: "Responder"}, {IncidentId: 2, Role: "Responder"}} mockIncidentRoles := []incident.IncidentRoleEntity{{IncidentId: 1, Role: "Responder"}, {IncidentId: 2, Role: "Responder"}}
incidentIds := []uint{1, 2} incidentIds := []uint{1, 2}
suite.incidentRepository.GetIncidentRolesByIncidentIdsAndRoleMock.Return(mockIncidentRoles, nil) suite.incidentRepository.GetIncidentRolesByIncidentIdsAndRoleMock.Return(mockIncidentRoles, nil)
incidentRoles, err := suite.incidentService.GetIncidentRolesByIncidentIdsAndRole(incidentIds, incident.Responder) incidentRoles, err := suite.incidentService.GetIncidentRolesByIncidentIdsAndRole(incidentIds, string(incident.Responder))
suite.NotNil(incidentRoles, "Incident roles should not be nil") suite.NotNil(incidentRoles, "Incident roles should not be nil")
suite.Equal(2, len(incidentRoles), "Incident roles should have 2 elements") suite.Equal(2, len(incidentRoles), "Incident roles should have 2 elements")
suite.Nil(err, "Error should be nil") suite.Nil(err, "Error should be nil")

2
service/reminder/team_incidents_reminder.go
View File

@@ -50,7 +50,7 @@ func (service *reminderServiceImpl) createResponderMapForIncidents(
incidentIds = append(incidentIds, incident.ID) incidentIds = append(incidentIds, incident.ID)
} }
incidentRoles, err := service.incidentService.GetIncidentRolesByIncidentIdsAndRole(incidentIds, incidentModel.Responder) incidentRoles, err := service.incidentService.GetIncidentRolesByIncidentIdsAndRole(incidentIds, string(incidentModel.Responder))
if err != nil { if err != nil {
logger.Error(fmt.Sprintf("error while fetching incident roles for incidents. %+v", err)) logger.Error(fmt.Sprintf("error while fetching incident roles for incidents. %+v", err))
return nil, err return nil, err