From 208df9f18cfbbc24f76754baf4e931902ce9013e Mon Sep 17 00:00:00 2001 From: Saqib Perwaiz Date: Tue, 26 Mar 2024 15:06:09 +0530 Subject: [PATCH] INFRA-3085 | Saqib | Format the code --- __tests__/helper/ChangeRequest.ts | 50 +++++++++++++++++++++---------- 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/__tests__/helper/ChangeRequest.ts b/__tests__/helper/ChangeRequest.ts index 8527fc9..b035ef7 100644 --- a/__tests__/helper/ChangeRequest.ts +++ b/__tests__/helper/ChangeRequest.ts @@ -56,15 +56,24 @@ describe('Change request test', () => { }, extraResources: { s3_buckets: { - "bucketTag" : "test-bucket", - "corsPolicy" : [], - "isDeployed" : false, - "bucketPolicy": "{\n \"Version\": \"2012-10-17\",\n \"Statement\": [\n {\n \"Effect\": \"Allow\",\n \"Principal\": \"*\",\n \"Action\": \"s3:GetObject\",\n \"Resource\": \"arn:aws:s3:::your-bucket-name/*\"\n }\n ]\n}", + "bucketTag": "test-bucket", + "corsPolicy": [], + "isDeployed": false, + "bucketPolicy": `{ + "Version": "2012-10-17", + "Statement": [ + { + "Effect": "Allow", + "Principal": "*", + "Action": "s3:GetObject", + "Resource": "arn:aws:s3:::your-bucket-name/*" + } + ] + }`, "lifecycleRules": [], "enableAccessLog": false, "enablePublicBucket": false, "anonymizedBucketName": "test-bucket" - } } }; @@ -326,13 +335,22 @@ describe('Change request test', () => { it('when diff in s3 policy', () =>{ const preS3ManifestObject = _.cloneDeep(sampleManifestObject); const s3ManifestObject = _.cloneDeep(sampleManifestObject); - const bucketPolicyCR = "{\n \"Version\": \"2012-10-17\",\n \"Statement\": [\n {\n \"Effect\": \"Deny\",\n \"Principal\": \"*\",\n \"Action\": \"s3:GetObject\",\n \"Resource\": \"arn:aws:s3:::your-bucket-name/*\"\n }\n ]\n}" - + const bucketPolicyCR = `{ + "Version": "2012-10-17", + "Statement": [ + { + "Effect": "Deny", + "Principal": "*", + "Action": "s3:GetObject", + "Resource": "arn:aws:s3:::your-bucket-name/*" + } + ] + }`; const limitObject = { extraResources: { s3_buckets: { bucketPolicy: { - approvalFrom: ['Infra'], + approvalFrom: ['Security'], textDiff: true, } }, @@ -341,14 +359,14 @@ describe('Change request test', () => { s3ManifestObject.extraResources.s3_buckets.bucketPolicy = bucketPolicyCR; const actual = getBreachedValues(limitObject, s3ManifestObject, preS3ManifestObject); - const expected = [ - { - op: 'replace', - path: '/extraResources/s3_buckets/bucketPolicy', - limitPath: '/extraResources/s3_buckets/bucketPolicy', - value: bucketPolicyCR, - } - ] + const expected = [ + { + op: 'replace', + path: '/extraResources/s3_buckets/bucketPolicy', + limitPath: '/extraResources/s3_buckets/bucketPolicy', + value: bucketPolicyCR, + } + ] expect(actual).toStrictEqual(expected); }) });