From 526d0dd7e4464c2ef2481d13bebf5f28be08d693 Mon Sep 17 00:00:00 2001 From: dhruvjoshi Date: Tue, 18 Jun 2024 12:52:01 +0000 Subject: [PATCH] INFRA-3354 | Dhruv | add check for the requestor user --- kutegen | 2 +- .../com/navi/infra/portal/v2/jit/service/JitServiceImpl.java | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/kutegen b/kutegen index fa1383cc..a91dfb85 160000 --- a/kutegen +++ b/kutegen @@ -1 +1 @@ -Subproject commit fa1383cc37cd73a68c85137c3d2724a059f2bab2 +Subproject commit a91dfb85311b62ea06fc7370c1bbb2f71d0c1c56 diff --git a/src/main/java/com/navi/infra/portal/v2/jit/service/JitServiceImpl.java b/src/main/java/com/navi/infra/portal/v2/jit/service/JitServiceImpl.java index e02a0458..d05da1de 100644 --- a/src/main/java/com/navi/infra/portal/v2/jit/service/JitServiceImpl.java +++ b/src/main/java/com/navi/infra/portal/v2/jit/service/JitServiceImpl.java @@ -473,6 +473,9 @@ class JitServiceImpl implements JitService { @Override public void handleOnCallJit(JitRequestDto jitRequestDto) throws IOException { + if (!jitRequestDto.getRequestedBy().equals(onCallApproverEmail)) { + throw new IllegalStateException("On call JIT request from unknown user"); + } jitUtil.overrideTeamForOnCallJit(jitRequestDto); JitRequest jitRequest = mapToJitRequest(jitRequestDto); log.info("On call JIT request received for {}", jitRequest.getRequestedFor().getEmail());