From 3ac92218263fe95bc4e9bd1669bb97a38035f6c2 Mon Sep 17 00:00:00 2001 From: Aman Sethi Date: Thu, 15 Jun 2023 15:50:19 +0530 Subject: [PATCH 1/2] remove offline saving feedback when online api failing tp-32780 --- src/action/dataActions.ts | 5 +++-- src/components/form/index.tsx | 15 ++++++++++----- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/action/dataActions.ts b/src/action/dataActions.ts index 43db1e5b..6f9d3c63 100644 --- a/src/action/dataActions.ts +++ b/src/action/dataActions.ts @@ -75,7 +75,8 @@ export const syncCaseDetail = onSuccessCB?: (data: any, actions?: any) => void; onErrorCB?: (e: Error) => void; }, - nextActions?: any + nextActions?: any, + isOnline?: boolean ) => (dispatch: AppDispatch) => { const offlineImageIdList = getOfflineImageId(payload); @@ -111,7 +112,7 @@ export const syncCaseDetail = type: 'error', text1: ToastMessages.FEEDBACK_FAILED, }); - if (updatedCaseDetail) { + if (updatedCaseDetail && !isOnline) { dispatch( updateCaseDetail({ caseId: payload.data.caseReferenceId, diff --git a/src/components/form/index.tsx b/src/components/form/index.tsx index 4ac86ef9..151eb9fa 100644 --- a/src/components/form/index.tsx +++ b/src/components/form/index.tsx @@ -187,12 +187,17 @@ const Widget: React.FC = (props) => { const unSyncedCase = getUnSyncedCase(updatedCase); const transformedPayload = await getTransformedCollectionCaseItem(unSyncedCase); dispatch( - syncCaseDetail(transformedPayload, updatedCase, { - onSuccessCB: onSuccessfulSubmit, - onErrorCB: () => { - setIsSubmitting(false); + syncCaseDetail( + transformedPayload, + updatedCase, + { + onSuccessCB: onSuccessfulSubmit, + onErrorCB: () => { + setIsSubmitting(false); + }, }, - }) + isOnline + ) ); } else { dispatch( From 2772d757ae87f23f6b57dd8123b64b4fbd80771d Mon Sep 17 00:00:00 2001 From: Aman Sethi Date: Mon, 19 Jun 2023 14:48:05 +0530 Subject: [PATCH 2/2] remove all cases dep tp-32780 --- src/screens/caseDetails/interactionsHandler.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/screens/caseDetails/interactionsHandler.tsx b/src/screens/caseDetails/interactionsHandler.tsx index d9e7d054..48142101 100644 --- a/src/screens/caseDetails/interactionsHandler.tsx +++ b/src/screens/caseDetails/interactionsHandler.tsx @@ -60,7 +60,7 @@ const interactionsHandler = () => { } } })(); - }, [allCasesDetails, isOnline]); + }, [isOnline]); return null; };